New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Wrong language passed to grammar checkers 'textidot' and 'vlty' #2190
Comments
It seems "languagetool --list" only works if a target file is also specified, e.g. "languagetool --list SOMEFILE". refer: #2190
textidotI've fixed a minor bug here, please test again now. vltyTo be honest, I'm no expert on this particular thing. After installing Yalafi and languagetool, I found it worked well when I removed the I'll ping the Yalafi dev to see if he has a comment here: @matze-dd Perhaps there's been changes to languagetool that breaks something? Or simply that we are not configuring things properly? @Konfekt: You also did some work on |
@lervag thanks for the quick response! I just tested the fix for textidot and now it is working correctly. vlty is also working for me after changing the configuration as you suggest. So all seems to be working now. I guess I should have tried to understand what those two options ( |
is fixed by b0798e5
seems to be an issue of vlty itself worked around as suggested by @lervag
The logic of this check was flawed. Above PR should fix it. Still, it could be that |
I think this is the problem. The command
I am using Archlinux and languagetool was installed from the repos. |
Heh, yeah. It's a common mistake :)
Thanks, I'll look into the PR as soon as possible. Edit: PR #2191 is merged.
This was already addressed by me in my earlier commit. |
This sounds like an issue with the |
I agree, but I'm not personally an avid user of languagetool, so I won't address that myself. |
Oh, well, if |
I just made a bit of research and found that the problem with the [1] https://bugs.archlinux.org/task/68079?project=0&order=id&sort=desc&string=languagetool |
Oh, thank you, @cristobaltapia, and sorry for forgetting that I went down this road a year ago. |
No problem @Konfekt ;) At least the workaround is straightforward, so I guess we can live with it until is fixed upstream. |
It seems to me we can close this issue, then, as there is no clear action to make on the VimTeX side? Or do you want to keep it open in the meantime? |
I think we can close this. Once there is an update from the side of the languagetool script, then we can either reopen this or create a new issue. |
Great, thanks! |
@cristobaltapia Vimtex is one of the most fantastic vim plugins I've ever seen. But you may have a better experience if using ale which focuses on linter. Because of lack of specific knowledge for the moment, I can't figure out how to use language tool now languagetool-org/languagetool#6290 (comment). |
<3
Today a lot of people are relying on LSP type plugins for linter backends. E.g., if you use coc.nvim or the neovim built-in lsp stuff, then you probably don't need ALE. See also
I'm no expert on languagetool stuff. Did you read the VimTeX docs on the matter, i.e. |
Vimtex is undoubtedly the most essential vim plugin for writing latex and a game-changer for me. Since there already has been a finished ale_linter, I may change my workflow after the paper deadline 😂 and I don't know how coc and neovim built-in lsp could do that, I mean English grammar checking rather than LaTeX syntax checking. I did read the doc ALE is configurable and also asynchronous and will also populate quickfix list, is an enough good "front end for language tool". I have no problem with that. But the key problem is language tool itself I mentioned above, so my reply may be off-topic although I want to discuss how to make language tool behave as it does on https://languagetool.org/ or how to find out more grammar mistakes when I use vim since Grammarly has no API for that as far as I'm concerned |
Glad to hear it! :)
Ah, yes, it's off topic. And I'm sorry to say I can't help with this. I don't use these things that much myself. Note, though, that perhaps you would find the LTeX language server useful? It relies on languagetool as well and I've heard good things of it. |
Description
When trying to use the grammar checkers 'textidot' or 'vlty' an error is displayed, saying that the language is unknown.
Steps to reproduce
I have the following configuration defined:
I define the spell language within the file with a modline:
Then run e.g.:
Expected behavior
Grammar check
Actual behavior
Errors occur.
Specifically,, textidote throws this error:
and vlty this:
As far as I understand, the correct language in this case should be
en_US
notenUS
noren-US
.Do you use a latexmkrc file?
no
VimtexInfo
The text was updated successfully, but these errors were encountered: