-
Notifications
You must be signed in to change notification settings - Fork 386
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add motion between frames #1853
Conversation
Thank you; I agree this is useful!
I don't mind the
Do you mean you don't want to propose the docs? I can probably add it myself if that's the case.
Don't worry, I think the PR smells of high quality. Before I merge, I would like to add a couple of tests in the |
Unfortunately, in the aforementioned plugin,
Yes, I meant that I didn't write any addition to the docs. But I can come up with something with the same method as the patch (aka copy-and-paste :-) ).
I don't mind helping out, but I am not familiar with this sort of things and I think won't be able to do it all by myself, sorry. In fact, are you asking to provide a MWE? |
Ok, no problem. Let's keep
Sounds good!
I think what would be good is a test similar to
Simply adding |
I pushed two commits, one with the docs update and one with the test. About the latter, it seems to work on my version of |
Thanks, this looks very good! I've tested and I fixed a minor annoyance (which was also present in some of the other motions) where the jump list was not properly set (i.e. doing |
It seems that I forgot to add the new motion in the README.md. I'll do a new PR. Sorry to bother again. |
I find the provided motions (by section, environment,...) very handy but I think it could be useful to have one by
frame
to make the editing ofbeamer
documents easier.I took the liberty to write a first version. I just took the environment-related functions and modified them a little bit. It seems to work on simple examples but I did not fully test it and there definitely is room to improvement.
I propose
r
-based shortcuts (so, for instance,]r
or[R
): I would have gone withf
, but it is already taken for instance in tpope/vim-unimpaired.No documentation is given.
Hope it could be useful.
(I'm very sorry if I did not follow the contributions rules, please have mercy of a Git newbie :-) )