Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

raise compile error when @Mapper is set on an interface #34

Closed
lesaint opened this issue Oct 27, 2014 · 1 comment
Closed

raise compile error when @Mapper is set on an interface #34

lesaint opened this issue Oct 27, 2014 · 1 comment
Assignees
@lesaint
Labels
enhancement
Milestone
0.5.0

Comments

@lesaint
Copy link
Owner

lesaint commented Oct 27, 2014

@Mapper annotation's target is java.lang.annotation.ElementType.TYPE which includes interfaces.

Having @Mapper on an interface does not make sense and current implementation just ignores it.

New implementation should raise a compilation error.
@lesaint lesaint added this to the 0.5.0 milestone Oct 27, 2014
@lesaint lesaint self-assigned this Nov 30, 2014
lesaint added a commit that referenced this issue Nov 30, 2014
@lesaint
[#34] raise comprehensive error when @Mapper is used on an interface
5f496f2 
add unit test for that
lesaint added a commit that referenced this issue Nov 30, 2014
@lesaint
[#34] improve several ERROR logs by attaching them to the element
c5fa83a
@lesaint
Copy link
Owner Author

lesaint commented Nov 30, 2014

done

Error already existed but there was no unit test and the error message wasn't attached to the Element (ie. the dedicated class).

@lesaint lesaint closed this as completed Nov 30, 2014
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@lesaint lesaint

Labels
enhancement
Projects
None yet
Milestone
0.5.0
Development

No branches or pull requests
1 participant
@lesaint