fix: tell browser about cookie expiry

Closes influxdata#17142
lesam · Mar 15, 2022 · 3ab1bff · 3ab1bff
1 parent 7d310c2
commit 3ab1bff
Show file tree

Hide file tree

Showing 2 changed files with 5 additions and 4 deletions.
diff --git a/session/http_server.go b/session/http_server.go
@@ -165,9 +165,10 @@ const cookieSessionName = "influxdb-oss-session"
 
 func encodeCookieSession(w http.ResponseWriter, s *influxdb.Session) {
 	c := &http.Cookie{
-		Name:  cookieSessionName,
-		Value: s.Key,
-		Path:  "/api/",
+		Name:    cookieSessionName,
+		Value:   s.Key,
+		Path:    "/api/",
+		Expires: s.ExpiresAt,
 	}
 
 	http.SetCookie(w, c)

diff --git a/session/http_server_test.go b/session/http_server_test.go
@@ -58,7 +58,7 @@ func TestSessionHandler_handleSignin(t *testing.T) {
 				password: "supersecret",
 			},
 			wants: wants{
-				cookie: "influxdb-oss-session=abc123xyz; Path=/api/",
+				cookie: "influxdb-oss-session=abc123xyz; Path=/api/; Expires=Thu, 26 Sep 2030 00:00:00 GMT",
 				code:   http.StatusNoContent,
 			},
 		},