Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Support ordered sublist #98

Closed
marcwrobel opened this issue Nov 20, 2022 · 0 comments · Fixed by #105
Closed

Support ordered sublist #98

marcwrobel opened this issue Nov 20, 2022 · 0 comments · Fixed by #105
Labels
enhancement New feature or request
Milestone
1.9.0

Comments

@marcwrobel
Copy link
Member

Ordered sublist are not properly handled during show notes generation.

For instance this :

- C’est sur le chemin du client
    1. Avant le premier contact
    2. Signature et premiere tâche transactionnelle (bien choisir la tache pour etre assez simple et ce que l’utilisateur répète)
    3. Premier moment de plaisir (regarder les points contre intuitifs dans les données, ou les cas d’utilisation en echec)

Is rendered as :

- C’est sur le chemin du client
- 1. Avant le premier contact
- 2. Signature et premiere tâche transactionnelle (bien choisir la tache pour etre assez simple et ce que l’utilisateur répète)
- 3. Premier moment de plaisir (regarder les points contre intuitifs dans les données, ou les cas d’utilisation en echec)
marcwrobel added a commit that referenced this issue Dec 7, 2022
@marcwrobel
Support ordered lists transformation (closes #98)
d30551f 
Ordered list transformation from slack syntax to markdown syntax were not supported: it was wrongly converted to simple lists.

It works only for ordered lists and sublists (not subsublist or more).
marcwrobel added a commit that referenced this issue Dec 7, 2022
@marcwrobel
Support ordered lists and sublists transformation (closes #98)
30c5844 
Ordered list and sublist transformation from Slack syntax to GitHub flavored markdown syntax were not supported: it was wrongly converted to simple lists.

It works only for ordered lists and sublists (not subsublists or more).
@marcwrobel marcwrobel linked a pull request Dec 7, 2022 that will close this issue
Support ordered lists and sublists transformation (closes #98) #105
Merged
marcwrobel added a commit that referenced this issue Dec 7, 2022
@marcwrobel
Support ordered lists and sublists transformation (closes #98)
26e393e 
Ordered list and sublist transformation from Slack syntax to GitHub flavored markdown syntax were not supported: it was wrongly converted to simple lists.

It works only for ordered lists and sublists (not subsublists or more). Slack syntax ordered sublist can contain at most 26 elements (a-z).
@marcwrobel marcwrobel added the enhancement New feature or request label Dec 13, 2022
@marcwrobel marcwrobel added this to the 1.9.0 milestone Dec 13, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
enhancement New feature or request
Projects
None yet
Milestone
1.9.0
Development

Successfully merging a pull request may close this issue.

Support ordered lists and sublists transformation (closes #98) lescastcodeurs/lcc-slack-bot
1 participant
@marcwrobel