Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Починить вызов get_all с несписочными методами #176

Merged
merged 1 commit into from
Jun 2, 2022

Conversation

leshchenko1979
Copy link
Owner

No description provided.

где в результатах нет поля `total`
Fixes #175
@sourcery-ai
Copy link

sourcery-ai bot commented Jun 2, 2022

Sourcery Code Quality Report

✅  Merging this PR will increase code quality in the affected files by 0.16%.

Quality metrics Before After Change
Complexity 1.32 ⭐ 1.25 ⭐ -0.07 👍
Method Length 25.25 ⭐ 25.29 ⭐ 0.04 👎
Working memory 4.11 ⭐ 4.03 ⭐ -0.08 👍
Quality 91.68% 91.84% 0.16% 👍
Other metrics Before After Change
Lines 148 154 6
Changed files Quality Before Quality After Quality Change
fast_bitrix24/server_response.py 89.91% ⭐ 89.88% ⭐ -0.03% 👎
tests/test_server_responses.py 93.65% ⭐ 93.80% ⭐ 0.15% 👍

Here are some functions in these files that still need a tune-up:

File Function Complexity Length Working Memory Quality Recommendation

Legend and Explanation

The emojis denote the absolute quality of the code:

  • ⭐ excellent
  • 🙂 good
  • 😞 poor
  • ⛔ very poor

The 👍 and 👎 indicate whether the quality has improved or gotten worse with this pull request.


Please see our documentation here for details on how these metrics are calculated.

We are actively working on this report - lots more documentation and extra metrics to come!

Help us improve this quality report!

@leshchenko1979 leshchenko1979 changed the title Leshchenko1979/issue175 Починить вызов get_all с несписочными методами Jun 2, 2022
@codecov
Copy link

codecov bot commented Jun 2, 2022

Codecov Report

Merging #176 (a287a42) into master (194e8ac) will decrease coverage by 0.20%.
The diff coverage is 66.66%.

@@            Coverage Diff             @@
##           master     #176      +/-   ##
==========================================
- Coverage   86.94%   86.74%   -0.21%     
==========================================
  Files           9        9              
  Lines         498      498              
==========================================
- Hits          433      432       -1     
- Misses         65       66       +1     
Impacted Files Coverage Δ
fast_bitrix24/server_response.py 89.79% <66.66%> (ø)
fast_bitrix24/correct_asyncio.py 75.00% <0.00%> (-25.00%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 194e8ac...a287a42. Read the comment docs.

@leshchenko1979 leshchenko1979 merged commit c4cad80 into master Jun 2, 2022
@leshchenko1979 leshchenko1979 deleted the leshchenko1979/issue175 branch June 2, 2022 20:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant