Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix typecheking and simplify call(raw=True) #183

Merged
merged 1 commit into from
Jun 8, 2022
Merged

Conversation

leshchenko1979
Copy link
Owner

No description provided.

@sourcery-ai
Copy link

sourcery-ai bot commented Jun 8, 2022

Sourcery Code Quality Report

❌  Merging this PR will decrease code quality in the affected files by 0.22%.

Quality metrics Before After Change
Complexity 1.05 ⭐ 1.05 ⭐ 0.00
Method Length 35.53 ⭐ 36.97 ⭐ 1.44 👎
Working memory 5.12 ⭐ 5.18 ⭐ 0.06 👎
Quality 87.37% 87.15% -0.22% 👎
Other metrics Before After Change
Lines 717 732 15
Changed files Quality Before Quality After Quality Change
fast_bitrix24/server_response.py 88.16% ⭐ 88.16% ⭐ 0.00%
fast_bitrix24/user_request.py 84.08% ⭐ 83.26% ⭐ -0.82% 👎
tests/test_server_responses.py 89.44% ⭐ 89.50% ⭐ 0.06% 👍
tests/test_sync.py 89.02% ⭐ 88.90% ⭐ -0.12% 👎

Here are some functions in these files that still need a tune-up:

File Function Complexity Length Working Memory Quality Recommendation
fast_bitrix24/user_request.py UserRequestAbstract.check_expected_clause_types 11 🙂 89 🙂 10 😞 59.93% 🙂 Extract out complex expressions
fast_bitrix24/user_request.py UserRequestAbstract.__init__ 0 ⭐ 60 ⭐ 10 😞 74.90% 🙂 Extract out complex expressions
tests/test_sync.py TestsWithLiveServer.TestBasic.test_issue_129 0 ⭐ 126 😞 5 ⭐ 77.29% ⭐ Try splitting into smaller methods

Legend and Explanation

The emojis denote the absolute quality of the code:

  • ⭐ excellent
  • 🙂 good
  • 😞 poor
  • ⛔ very poor

The 👍 and 👎 indicate whether the quality has improved or gotten worse with this pull request.


Please see our documentation here for details on how these metrics are calculated.

We are actively working on this report - lots more documentation and extra metrics to come!

Help us improve this quality report!

@codecov
Copy link

codecov bot commented Jun 8, 2022

Codecov Report

Merging #183 (cf4a8b2) into master (036a45a) will decrease coverage by 0.09%.
The diff coverage is 100.00%.

@@            Coverage Diff             @@
##           master     #183      +/-   ##
==========================================
- Coverage   87.89%   87.80%   -0.10%     
==========================================
  Files           9        9              
  Lines         504      500       -4     
==========================================
- Hits          443      439       -4     
  Misses         61       61              
Impacted Files Coverage Δ
fast_bitrix24/server_response.py 92.98% <100.00%> (ø)
fast_bitrix24/user_request.py 88.81% <100.00%> (-0.31%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 036a45a...cf4a8b2. Read the comment docs.

@leshchenko1979 leshchenko1979 merged commit 4922d50 into master Jun 8, 2022
@leshchenko1979 leshchenko1979 deleted the fix-raw-call branch June 8, 2022 18:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant