Websocketpp example

[acgreek]

The websocketpp client connects to the websocket tls server but doesn't complete the tls handshake. For reference, I confirmed the websocketpp client is able to connect and send data to wss://echo.websocket.org

[lesismal]

so it is all right with llib 1.0.0?

[acgreek]

No, a have a developer still having issues with websocketpp/asio; the stream comes in corrupt. I haven't been able to reproduce with my simple example yet and am busy today.

…

On Thu, Jun 17, 2021, 9:53 AM lesismal ***@***.***> wrote: so it is all right with llib 1.0.0? — You are receiving this because you modified the open/close state. Reply to this email directly, view it on GitHub <#22 (comment)>, or unsubscribe <https://github.com/notifications/unsubscribe-auth/AAJSWET2Q4HQLWCCGQANMNLTTH46PANCNFSM463S5UFQ> .

[lesismal]

I reproduced this bug with your cpp example.

this commit works fine now, please try it.

[acgreek]

wow thanks, I didn't want to trouble you until I was certain. I'm think the problem was with websocketpp on linux as opposed to macos as it my personal developer laptop; the developer who reported issue is using linux. Is that the case; did you confirm the problem with linux?

[lesismal]

wow thanks, I didn't want to trouble you until I was certain. I'm think the problem was with websocketpp on linux as opposed to macos as it my personal developer laptop; the developer who reported issue is using linux. Is that the case; did you confirm the problem with linux?

This is a half-frame-parsing bug, and all platforms should be affected.

The TLSConn uses the same buffer to read data, then passes the buffer to websocket.Upgrader to parse frame/message.
When there's only a half-frame, the upgrader will cache the buffer, it should make a copy of the buffer if needed, but there's a bug for the copying logic and the upgrader does not copy it.
When the Conn.Read next time, the buffer is overwritten which makes the upgrader's cache dirty, then everything goes wrong.

Thank you for pointing out this bug!

Please continue to monitor your service, if no more problems are found, we could release v1.0.3.

[acgreek]

yes, developer confirmed this worked. Thank you so much

[lesismal]

yes, developer confirmed this worked. Thank you so much

my pleasure, you are welcome