Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix bad relative hyperlink to features page #489

Closed
wants to merge 1 commit into from

Conversation

bburhans
Copy link

Apologies if this is incorrect; I think it's accurate based on the assemble-generated paths on the actual web site, ignoring the very broken github markdown viewer paths.

@matthew-dean
Copy link
Member

ignoring the very broken github markdown viewer paths

Explain?

@bburhans
Copy link
Author

bburhans commented Oct 2, 2018

Relative URLs in markdown links are relative to a different base URL when rendered on github, because of the use of the assemble static site generator.

http://lesscss.org/functions/#logical-functions-if has a link to features/#mixins-feature-mixin-guards-feature which points to http://lesscss.org/functions/features/#mixins-feature-mixin-guards-feature, which does not exist. On github, it would point to yet another broken link either way. This pull simply fixed the former and ignored the latter, because this project does not and should not care about browsing the docs directly from github, correct?

@seven-phases-max
Copy link
Member

seven-phases-max commented Mar 10, 2019

Closing as done in f5c5f8b (Though I'm still not sure what would be the proper way to write such links... Could be also ../features...?)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants