Promise returned by render has or has not .done() method, depending on environment.

[OJezu]

Less.js is using then/promise as shim for Promise if it is not provided by environment. However, promises as created by then/promise have non-standard (but very useful!) .done() method while native ones do not. Which leads to inconsistency.

Related: gulp-community/gulp-less#140 - render().done() is not a function, but only with modern v8.

[lukeapage]

I don't want to have to always use a dependency just for one function. If the done function becomes standard we can test for it in the native implementation and then decide which version to use. Other team members might disagree so I'm leaving this NeedsDecision

[OJezu]

@lukeapage npm will always (at least try to) download then/promise, so if it is there you might as well always use it.
Other solution would be to use a promise-shim that does not surpass standard.

[lukeapage]

Yes ive considered that (changing to pure shim) and its maybe what we should do. Actually alot of people install less with no optional option to npm which does not include optional deps.

[OJezu]

I think --no-optional would break things on node v0.10, as then it tries to load then/promise which is not installed.

[lukeapage]

Only if you dont pass in a callback. I was using promises internally but then its forced async callback interfered with our sync option, which seems to be used alot in browser and node environments where for some reasons its not practical to be async :(

[stale]

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.