-
Notifications
You must be signed in to change notification settings - Fork 3.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
// comments inside .less files will stop applying the rulesets #3803
Comments
To be more precise here, this is an example (.less File) // disables the whole ruleset, just because it's // instead of /**/ h1 { font-size: 20px; /* works, when above // is changed into normal css-comments */ /* // color: #FFFFFF; */ background-color: #000000; /* rule does not work, once the above comment is // only */ } |
Sorry, problem solved, since everything else less normally offers also didn't work either with that specific file I got suspicious. If anybody has had the same problem, make sure you include the .less file as I recently renamed a .css into a .less file and also included the less-parser properly, which went through without any errors, so I didn't catch the problem firsthand. So, here is a feature request: |
@Neohiro79 i guess the problem is resolved please close the issue. |
So, there is no thought or comment on my follow-up feature-request to make the less-parser detect a potentially wrongly embedded less-filetype through ie.
then comparing the suffix of the filename
|
@Neohiro79 my apologies, missed a couple of lines, thought the issue to be resolved |
@Cyddharth-Gupta No problem - I just thought that it would make sense after I discovered that a google search completely mislead me to find/locate this error which took me some hours. It get's "parsed" without an error, in case you include a .less file but with text/css inside the rel attribute. Also, additional to my proposal there should be also the opposite case covered (ie. ".css" is there but "text/less" is the rel/type value):
and also in case ".less" is there but only "text/css" is written in the rel/type-attribute:
That would cover the basic pitfalls which can always happen when including more than one file (or even in case you just don't know or forgot) |
In web requests, a file extension cannot actually tell you what type of file it is, because you can easily set up something like a |
To reproduce:
Just make a rule inside a .less file and start "commenting" via "//" above or inside the rulesets. Those rulesets won't work.
As soon as you "change" or encapsule those comments via the usual "/* */" comments, the rule gets applied as expected.
Current behavior:
CSS rules won't be applied as expected - Chrome Dev Tools reports them as "unknown property name"
Expected behavior:
As far as I know, "less" allowes "//" comments inside the ".less-Files". When using .less Parser, I expect the CSS rules to work as intended (at least that's what I am aware of).
Environment information:
less
version: latest less version / Less - Leaner CSS v4.1.3nodejs
version: no node installed / usage via normal xampp environmentoperating system
: windowsThe text was updated successfully, but these errors were encountered: