Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Question: Is the description for --source-map-url CLI option incorrect? #2264

Closed
am11 opened this issue Nov 1, 2014 · 4 comments · Fixed by #2267
Closed

Question: Is the description for --source-map-url CLI option incorrect? #2264

am11 opened this issue Nov 1, 2014 · 4 comments · Fixed by #2267

Comments

@am11
Copy link
Contributor

am11 commented Nov 1, 2014

@lukeapage, @seven-phases-max,

It says the complete url and filename put in the less file. Since sourceMappingURL resides in CSS, shouldn't it say: the complete url and filename put in the CSS (or generated / output) file?
@seven-phases-max
Copy link
Member

Yes, I guess so. It seems the docs have it more correct:

Allows you to override the URL in the css that points at the map file.

@am11
Copy link
Contributor Author

am11 commented Nov 1, 2014

Yes, I think it needs to be reworded in lessc-helper.js.

Incidentally, in this case,it would just stamp out the user provided URL string in sourceMappingURL as is; no alteration (validation, path resolving) to it whatsoever?

@am11 am11 mentioned this issue Nov 1, 2014
Closed
6 tasks
@seven-phases-max
Copy link
Member

OK, I guess I leave this fix to @LukePage (since I'm not even sure if this thing points to or at :).
@am11 or maybe you could do a PR?

am11 added a commit to am11/less.js that referenced this issue Nov 2, 2014
@am11
CLI: Fixes source-map-url description. (less#2264)
be2de92
@am11 am11 mentioned this issue Nov 2, 2014
Merged
@am11
Copy link
Contributor Author

am11 commented Nov 2, 2014

@seven-phases-max, this is fixed by be2de92 via #2267.

lukeapage added a commit that referenced this issue Nov 3, 2014
@lukeapage
Merge pull request #2267 from am11/master
dd1ebe8 
CLI: Fixes source-map-url description (#2264)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

CLI: Fixes source-map-url description (#2264) am11/less.js
2 participants
@am11 @seven-phases-max