Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update postcss-values-parser to 1.2.0 #340

Closed
greenkeeper bot opened this issue Feb 10, 2017 · 4 comments · Fixed by shellscape/postcss-values-parser#24
Closed

Update postcss-values-parser to 1.2.0 #340

greenkeeper bot opened this issue Feb 10, 2017 · 4 comments · Fixed by shellscape/postcss-values-parser#24

Comments

@greenkeeper
Copy link
Contributor

greenkeeper bot commented Feb 10, 2017

Version 1.2.0 of postcss-values-parser just got published.

Branch Build failing 🚨
Dependency postcss-values-parser
Current Version 1.1.0
Type dependency

This version is covered by your current version range and after updating it in your project the build failed.

As postcss-values-parser is a direct dependency of this project this is very likely breaking your project right now. If other packages depend on you it’s very likely also breaking them.
I recommend you give this issue a very high priority. I’m sure you can resolve this 💪


Status Details
  • continuous-integration/travis-ci/push The Travis CI build is in progress Details

  • continuous-integration/appveyor/branch AppVeyor build failed Details

Commits

The new version differs by 3 commits .

  • 7346e7c 1.2.0
  • 851238c adding more operator parsing conditions, limiting certain operator conditions to calc(), correcting operator parse errors
  • ae6c1b6 update README for 1.1.0

See the full diff.

Not sure how things should work exactly?

There is a collection of frequently asked questions and of course you may always ask my humans.


Your Greenkeeper Bot 🌴

@shellscape
Copy link
Contributor

shellscape commented Feb 10, 2017

@jwilsson the tests here shellscape/postcss-values-parser@851238c#diff-cc37320af8aeb8b7582dad90cc114e55 should shed some light on what changed. the parser wasn't handling conditions outside of calc correctly. this should be an easy test update to get it working.

stuff like 5 +5 and 5+5 are actually considered to be two separate words: 5 and +5, unless inside calc in which case it's a syntax error. in the case of 5+ 5 for example, since the operator token (+) is followed by a space, it should be treated as an operator, rather than the sign of the following number, which is why 5 +5 gets evaluated differently. that holds true between CSS and CSS-like languages.

fucking tricky stuff. made my brain melt this morning.

@jwilsson
Copy link
Member

jwilsson commented Feb 10, 2017

@shellscape Cool, thanks for the explanation!

I'll take a look over the weekend.

@jwilsson jwilsson changed the title An in-range update of postcss-values-parser is breaking the build 🚨 Update postcss-values-parser to 1.2.0 Feb 11, 2017
@jwilsson
Copy link
Member

Turned out to be a bit more work than expected. But there's no rush in updating either, I'll keep this issue open for tracking and the version range at ~

@jwilsson
Copy link
Member

jwilsson commented Mar 24, 2017

For future reference, the failing build: https://travis-ci.org/lesshint/lesshint/builds/200394096

spaceAroundOperator is the culprit.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants