Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Copied! tooltip does not appear when you copy the password with the keyboard #248

Closed
panther2 opened this issue Jul 19, 2017 · 5 comments
Closed

Comments

@panther2
Copy link
Contributor

I have tried not only to generate the password using the keyboard only but to copy the generated password to the clipboard, too.

While it is IMHO intuitive, to hit enter to generate the password, I have just found out only by accident that I need to hit Tab and then space to copy the generated password to the clipboard.
Also when doing so I don't get a "copied" popup as when using the mouse, although the password is definitely copied using the keyboard as described.

Is there a more elegant way to copy only using the keyboard?
Can there be a pop-up confirmation, too?

@guillaumevincent
Copy link
Member

enter > tab > enter

Copy to clipboard doesn't work with async method. So we need to do the generate with 2 steps.
I'm not sure the pop up is good in term of UI.

Let me try to improve the copied! feedback.

@guillaumevincent guillaumevincent changed the title Chrome extension and workflow by using the keyboard Copied! tooltip does not appear when you copy the password with the keyboard Jul 19, 2017
@panther2
Copy link
Contributor Author

panther2 commented Jul 19, 2017

Thank you! I thought I had tried enter tab enter (that is very intuitive, too) during my tests without effect, but I can confirm now that it works fine.

@panther2
Copy link
Contributor Author

@guillaumevincent

It appears that with extension 2.5.0 the process has become more complicated.

Now it is

enter tab enter tab enter

instead of enter tab enter before...

@guillaumevincent
Copy link
Member

@panther2 https://github.com/lesspass/pure/commit/09a878f2538e6a0f965d9ec8393f44c2db2a924f fixes the enter tab enter feature

@panther2
Copy link
Contributor Author

@guillaumevincent
Tested and works fine! Thank you!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants