Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Work with iat == now (truncated down to second) #41

Merged
merged 7 commits into from
Feb 21, 2018
Merged

Conversation

lestrrat
Copy link
Collaborator

merges #40, and fixes #37

wvh and others added 5 commits February 15, 2018 17:07
…created

Verify() truncates the time in the `iat` field and Now() to the nearest second when comparing so the `iat` claim fails because Now() is not after `iat` when checking the validity of the token within the same second.
wvh and others added 2 commits February 19, 2018 15:25
Avoid comparing time structs directly because the time zone may be different
@lestrrat lestrrat merged commit 7d156a6 into master Feb 21, 2018
@lestrrat lestrrat deleted the topic/iat-skew branch February 21, 2018 00:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Consider not rounding time or set skew to 1 in token validation
2 participants