Skip to content
This repository has been archived by the owner on May 31, 2023. It is now read-only.

Commit

Permalink
Always use Linux version of test_coding_rules
Browse files Browse the repository at this point in the history
Because only Linux version of this tool is fully functional (while the
MSW one just exits with an error), always use it, even in the build
targeting MSW.

This is enough to make concinnity checks to work in any build.
  • Loading branch information
vadz committed Sep 11, 2021
1 parent 7847bc6 commit a021d18
Showing 1 changed file with 9 additions and 3 deletions.
12 changes: 9 additions & 3 deletions GNUmakefile
Original file line number Diff line number Diff line change
Expand Up @@ -431,11 +431,17 @@ uninstall:

# Custom tools built from source.

TEST_CODING_RULES := $(build_dir)/test_coding_rules$(EXEEXT)
# Always build the Linux version of this tool, as it depends on PCRE library
# only available on POSIX systems and it is preferable to run it on the host,
# rather than the target, system in any case.
#
# Note that this implies that the binary doesn't need to use EXEEXT and that
# PERFORM should _not_ be used when running it.
TEST_CODING_RULES := $(build_dir)/test_coding_rules

.PHONY: custom_tools
custom_tools:
@$(MAKE) test_coding_rules$(EXEEXT)
@$(MAKE) LMI_TRIPLET=x86_64-pc-linux-gnu test_coding_rules
@$(INSTALL) -c -m 0775 $(TEST_CODING_RULES) $(localbindir)

################################################################################
Expand Down Expand Up @@ -501,7 +507,7 @@ check_concinnity: source_clean custom_tools
|| $(ECHO) "... in file $$z"; \
done;
@$(ECHO) " Miscellaneous problems:"
@cd $(prefascicle_dir) && $(PERFORM) $(TEST_CODING_RULES) *
@cd $(prefascicle_dir) && $(TEST_CODING_RULES) *

################################################################################

Expand Down

0 comments on commit a021d18

Please sign in to comment.