Skip to content
This repository has been archived by the owner on May 31, 2023. It is now read-only.

Commit

Permalink
Fail concinnity check if there are any coding rules test failures
Browse files Browse the repository at this point in the history
The changes of a9bc62f (Count coding-rules complaints, 2021-06-28)
made test_coding_rules exit with a non-zero exit code if any coding
rules violations were found, but the check_concinnity makefile target
still explicitly ignored the failure by using "-" in the make recipe.

It is not really clear why was the exit code of test_coding_rules
ignored in the first place, as it hadn't been done for the checks
performed in the makefile itself prior to the introduction of a separate
test_coding_rules program in 7afe844 (Quadruple the speed of 'make
check_conformity', 2006-01-18), but it remained the case ever since.

Stop doing it now and do fail if either any real problems are found or
when running the stub version of test_coding_rules built on the systems
without PCRE.
  • Loading branch information
vadz committed Sep 5, 2021
1 parent 86f723e commit f4a679d
Showing 1 changed file with 1 addition and 1 deletion.
2 changes: 1 addition & 1 deletion GNUmakefile
Original file line number Diff line number Diff line change
Expand Up @@ -501,7 +501,7 @@ check_concinnity: source_clean custom_tools
|| $(ECHO) "... in file $$z"; \
done;
@$(ECHO) " Miscellaneous problems:"
@-cd $(prefascicle_dir) && $(PERFORM) $(TEST_CODING_RULES) *
@cd $(prefascicle_dir) && $(PERFORM) $(TEST_CODING_RULES) *

################################################################################

Expand Down

0 comments on commit f4a679d

Please sign in to comment.