Issue/#38 #40
Merged
Issue/#38 #40
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
letelete
added a commit
that referenced
this pull request
Sep 22, 2018
* Prepare code for add alarms to realm from other tabs (#29) * Add initial EventBus setup * Refactor Alarm classess, remove add item to alarm option for now * Add more dependencies to .gitignore * Resolve 2 issues (#31) * Add feature: double back press to exit, Issue #17 * Apply style for TimePicker in dark mode, Issue #8 * Change ic_access_alarm foreground color, Issue #2 (#36) * Fix bug with navigation bar, solve issue #32 (#37) * Add informative toast, issue #16 (#39) * Set screen orientation to portrait only in all activities, issue #38 (#40) * Issue/#42 (#44) * Change TAGs to match theirs class names * Refactor ItemBuilder classes to make them consistent and cleaner * Refactor count down function in MainContract to make it functionality easier to understand * Change names of items builder classes * Fix issue #42 * Refactor ItemBuilders, Add save state of list feature, Fix unit tests, a dd more unit test * Clean a code * Add temporary solution for showTheClosestAlarmToDefinedHour() * Fix issue #42 * Add Issue #45 feature, make WakeUpAt's layout dynamic (#47) * Remove redundant layout file * Add basic animation implementation * Change list layout from static to dynamic * Update layout (#49) * Fix wake up at layout * Remove image * Replace constraint layout in cardListView to Linear * Replace ImageView with FrameLayout * Add emptyListPlaceholderStyle * Add empty list image to alarms, make the recyclerView layout dynamic * Center toolbarTitle textView horizontally to match overflow menu * Add padding to sleep now list * WakeUpAt code rearrangement (#51) * Refactor onActivityCreated function in WakeUpAtPresenter * Rearange code contract for WakeUpAt view and presenter * Clean view from business logic and move everything business-like to the presenter * Remove redundant function * Items builder improvement (#52) * Implement strategy pattern for ItemsBuilder, Add tests * Add more tests that covers all opportunities * Add info about method of naming convention * Add more tests in getSummaryTests * Change code structure of Alarms to dual Contract MVP * Add AlarmManager, refactor AlarmsPresenter * Create simple subscriber to set alarm event * Implement show and hide UI elements system at Alarms tab * Improve realm connections over app, add onRealmChangeListener to Alarms tab * Add WakeUpAt subscriber to connect with alarm manager * Create MyViewManager to avoid repeating myself * Refactor methods to hide/show at WakeUpAtFragment, move MyViewManager to the utility directory
letelete
added a commit
that referenced
this pull request
Sep 22, 2018
* Update README with new logo position and icons (#43) * Update README with new logo position * Update icons * Change warning icon to pin * Alarms manager issue #35 (#54) * Prepare code for add alarms to realm from other tabs (#29) * Add initial EventBus setup * Refactor Alarm classess, remove add item to alarm option for now * Add more dependencies to .gitignore * Resolve 2 issues (#31) * Add feature: double back press to exit, Issue #17 * Apply style for TimePicker in dark mode, Issue #8 * Change ic_access_alarm foreground color, Issue #2 (#36) * Fix bug with navigation bar, solve issue #32 (#37) * Add informative toast, issue #16 (#39) * Set screen orientation to portrait only in all activities, issue #38 (#40) * Issue/#42 (#44) * Change TAGs to match theirs class names * Refactor ItemBuilder classes to make them consistent and cleaner * Refactor count down function in MainContract to make it functionality easier to understand * Change names of items builder classes * Fix issue #42 * Refactor ItemBuilders, Add save state of list feature, Fix unit tests, a dd more unit test * Clean a code * Add temporary solution for showTheClosestAlarmToDefinedHour() * Fix issue #42 * Add Issue #45 feature, make WakeUpAt's layout dynamic (#47) * Remove redundant layout file * Add basic animation implementation * Change list layout from static to dynamic * Update layout (#49) * Fix wake up at layout * Remove image * Replace constraint layout in cardListView to Linear * Replace ImageView with FrameLayout * Add emptyListPlaceholderStyle * Add empty list image to alarms, make the recyclerView layout dynamic * Center toolbarTitle textView horizontally to match overflow menu * Add padding to sleep now list * WakeUpAt code rearrangement (#51) * Refactor onActivityCreated function in WakeUpAtPresenter * Rearange code contract for WakeUpAt view and presenter * Clean view from business logic and move everything business-like to the presenter * Remove redundant function * Items builder improvement (#52) * Implement strategy pattern for ItemsBuilder, Add tests * Add more tests that covers all opportunities * Add info about method of naming convention * Add more tests in getSummaryTests * Change code structure of Alarms to dual Contract MVP * Add AlarmManager, refactor AlarmsPresenter * Create simple subscriber to set alarm event * Implement show and hide UI elements system at Alarms tab * Improve realm connections over app, add onRealmChangeListener to Alarms tab * Add WakeUpAt subscriber to connect with alarm manager * Create MyViewManager to avoid repeating myself * Refactor methods to hide/show at WakeUpAtFragment, move MyViewManager to the utility directory * Revert "Alarms manager issue #35 (#54)" This reverts commit eadcf48.
letelete
added a commit
that referenced
this pull request
Sep 24, 2018
* Prepare code for add alarms to realm from other tabs (#29) * Add initial EventBus setup * Refactor Alarm classess, remove add item to alarm option for now * Add more dependencies to .gitignore * Resolve 2 issues (#31) * Add feature: double back press to exit, Issue #17 * Apply style for TimePicker in dark mode, Issue #8 * Change ic_access_alarm foreground color, Issue #2 (#36) * Fix bug with navigation bar, solve issue #32 (#37) * Add informative toast, issue #16 (#39) * Set screen orientation to portrait only in all activities, issue #38 (#40) * Issue/#42 (#44) * Change TAGs to match theirs class names * Refactor ItemBuilder classes to make them consistent and cleaner * Refactor count down function in MainContract to make it functionality easier to understand * Change names of items builder classes * Fix issue #42 * Refactor ItemBuilders, Add save state of list feature, Fix unit tests, a dd more unit test * Clean a code * Add temporary solution for showTheClosestAlarmToDefinedHour() * Fix issue #42 * Add Issue #45 feature, make WakeUpAt's layout dynamic (#47) * Remove redundant layout file * Add basic animation implementation * Change list layout from static to dynamic * Update layout (#49) * Fix wake up at layout * Remove image * Replace constraint layout in cardListView to Linear * Replace ImageView with FrameLayout * Add emptyListPlaceholderStyle * Add empty list image to alarms, make the recyclerView layout dynamic * Center toolbarTitle textView horizontally to match overflow menu * Add padding to sleep now list * WakeUpAt code rearrangement (#51) * Refactor onActivityCreated function in WakeUpAtPresenter * Rearange code contract for WakeUpAt view and presenter * Clean view from business logic and move everything business-like to the presenter * Remove redundant function * Items builder improvement (#52) * Implement strategy pattern for ItemsBuilder, Add tests * Add more tests that covers all opportunities * Add info about method of naming convention * Add more tests in getSummaryTests * Implement Alarms manager - issue #35 (#56) * Change code structure of Alarms to dual Contract MVP * Add AlarmManager, refactor AlarmsPresenter * Create simple subscriber to set alarm event * Implement show and hide UI elements system at Alarms tab * Improve realm connections over app, add onRealmChangeListener to Alarms tab * Add WakeUpAt subscriber to connect with alarm manager * Create MyViewManager to avoid repeating myself * Refactor methods to hide/show at WakeUpAtFragment, move MyViewManager to the utility directory * Change files structure (#58) * Reorganize project files, update dependencies, create gradle variable for support dependency * Add gradlew permissions in travis file * Add abortOnError lint option and set it to false, change namespace URI in themes.xml * Fix: Execution failed for task :app:connectedDebugAndroidTest
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.