Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Don't through exception when HTML title is empty #1

Merged
merged 1 commit into from
Jan 25, 2013
Merged

Don't through exception when HTML title is empty #1

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions extraction/__init__.py
View file
Open in desktop
Original file line number Original file line Diff line number Diff line change
Expand Up @@ -207,7 +207,7 @@ def cleanup(self, results, html, source_url=None):
cleaned_results = {} cleaned_results = {}
for data_type, data_values in results.items(): for data_type, data_values in results.items():
if data_type in self.text_types: if data_type in self.text_types:
data_values = [self.cleanup_text(x) for x in data_values] data_values = [self.cleanup_text(x) for x in filter(None, data_values)]
if data_type in self.url_types: if data_type in self.url_types:
data_values = [self.cleanup_url(x, source_url=source_url) for x in data_values] data_values = [self.cleanup_url(x, source_url=source_url) for x in data_values]


Expand All @@ -218,7 +218,7 @@ def cleanup(self, results, html, source_url=None):
unique_values.append(data_value) unique_values.append(data_value)


cleaned_results[data_type] = unique_values cleaned_results[data_type] = unique_values

return cleaned_results return cleaned_results


def extract(self, html, source_url=None): def extract(self, html, source_url=None):
Expand Down
12 changes: 12 additions & 0 deletions extraction/tests/data.py
View file
Open in desktop
Original file line number Original file line Diff line number Diff line change
Expand Up @@ -146,3 +146,15 @@
</body> </body>
</html> </html>
""" """

EMPTY_TITLE_HTML = """
<html>
<head>
<title></title>
</head>
<body>
<h2>H2</h2>
<h1>H1</h1>
<h1>H1 2</h1>
</body>
</html>"""
4 changes: 4 additions & 0 deletions extraction/tests/tests.py
View file
Open in desktop
Original file line number Original file line Diff line number Diff line change
Expand Up @@ -119,6 +119,10 @@ def test_example_new_return_type(self):
self.assertEqual(extracted.description, None) self.assertEqual(extracted.description, None)
self.assertEqual(extracted.image, None) self.assertEqual(extracted.image, None)


def test_empty_title(self):
"Test that HTML with an empty title sets first h1 heading as title."
extracted = self.extractor.extract(EMPTY_TITLE_HTML)
self.assertEqual(extracted.title, "H1")


if __name__ == '__main__': if __name__ == '__main__':
unittest.main() unittest.main()