Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Fix] Delete all data in frontend/ folder (dev-branch) #21

Merged
merged 1 commit into from
Mar 10, 2023
Merged

[Fix] Delete all data in frontend/ folder (dev-branch) #21

merged 1 commit into from
Mar 10, 2023

Conversation

letiendat1002
Copy link
Owner

  1. Xóa dữ liệu trong folder frontend trong branch dev do push trực tiếp từ @quanghuy89 khi chưa có bộ rule cụ thể.
  2. Tạo protection rule cho dev tương tự như master tránh cho việc push code trực tiếp mà tất cả phải thông qua PR để review.
  3. Một số lưu ý về conflict, đặt tên branch feature được gửi trong group mọi người xem qua và thực hiện theo nhé.

@letiendat1002 letiendat1002 added the bug Report general errors/bugs label Mar 9, 2023
@letiendat1002 letiendat1002 self-assigned this Mar 9, 2023
@letiendat1002 letiendat1002 changed the title [Fix] Delete all data in frontend/ folder [Fix] Delete all data in frontend/ folder (dev-branch) Mar 9, 2023
quanghuy89
quanghuy89 approved these changes Mar 10, 2023
View reviewed changes
Copy link
Collaborator

@quanghuy89 quanghuy89 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Done

@quanghuy89 quanghuy89 self-requested a review March 10, 2023 09:42
@letiendat1002 letiendat1002 merged commit 11e5143 into dev Mar 10, 2023
@letiendat1002 letiendat1002 deleted the revert-front-end branch March 10, 2023 09:48
@letiendat1002 letiendat1002 added optimize Optimize feature or request and removed bug Report general errors/bugs labels Apr 9, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@quanghuy89 quanghuy89 quanghuy89 approved these changes

Assignees

@letiendat1002 letiendat1002

Labels
optimize Optimize feature or request
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@letiendat1002 @quanghuy89