Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Eurocom Sky MX5 support. #1

Closed
wants to merge 1 commit into from
Closed

Add Eurocom Sky MX5 support. #1

wants to merge 1 commit into from

Conversation

cono
Copy link

@cono cono commented May 5, 2016

Improve dmidecode parsing, as dmidecode prints warning for me and
system-product-name validation fails.

% sudo dmidecode -q -s system-product-name            
# SMBIOS implementations newer than version 2.8 are not
# fully supported by this version of dmidecode.
SKY MX5

Delete SMBus.close as I don't see this method in SMBus class.

Traceback (most recent call last):
  File "./init-headphone", line 148, in <module>
    success = init_headphone()
  File "./init-headphone", line 144, in init_headphone
    i2c_bus.close()

Improve dmidecode parsing, as dmidecode prints warning for me and
system-board validation fails.
Delete SMBus.close as I don't see this method in SMBus class.
@letitz
Copy link
Owner

letitz commented May 6, 2016

First off, thanks for contributing!
I wonder, does unrud's latest code work for you? This repo is just a fedora packaging of his original fix, so I think the way to go is to submit this PR upstream, and I can merge in his updates.

@cono
Copy link
Author

cono commented May 6, 2016

Actually already got reply from Unrud that he has this fix applied before and your script just outdated. And yes his current version works fine for my laptop. So merging his changes to your repo would be perfect.
And I'm closing this merge request.
Thanks! :)

@cono cono closed this May 6, 2016
@letitz
Copy link
Owner

letitz commented May 6, 2016

I just updated the repo to reflect unrud's master. Can you test it and see if it works for you?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
2 participants