Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix the end extend of actions in dismiss animation #38

Merged
merged 4 commits into from Oct 15, 2018
Merged

fix the end extend of actions in dismiss animation #38

merged 4 commits into from Oct 15, 2018

Conversation

miDeb
Copy link
Contributor

@miDeb miDeb commented Oct 15, 2018

The end extend of secondary actions must be smaller, since their position is not at the same point as the primary action (ie. the Offset zero).

before:

dismiss_before

after:

dismiss_after

A workaround would be to wrap the ListTile with a Container and set a color.

@letsar
Copy link
Owner

letsar commented Oct 15, 2018

Hi @miDeb , thanks for this PR.
This is strange, I cannot reproduce the before use case with the current source code. But I think you're right, the end extent should be different for each actions.
Under which Flutter version are you?
Can you paste here the complete sample please, so that I can reproduce and understand before I merge this?

@letsar
Copy link
Owner

letsar commented Oct 15, 2018

Oh I think I know why. This is because I have a white background in my tiles and it's transparent in your case

@letsar letsar merged commit ba45d60 into letsar:master Oct 15, 2018
@letsar
Copy link
Owner

letsar commented Oct 15, 2018

Published in v0.4.9

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants