Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fandom-cleanup: add new template for Wikia sites #491

Merged
merged 12 commits into from Jul 6, 2023
Merged

fandom-cleanup: add new template for Wikia sites #491

merged 12 commits into from Jul 6, 2023

Conversation

JohnyP36
Copy link
Member

@JohnyP36 JohnyP36 commented Jul 5, 2023

I'm working on making a template for issue #490

@github-actions
Copy link
Contributor

github-actions bot commented Jul 5, 2023 •
edited

Thanks for your contribution! The automated tests passed, we will review your PR shortly!

@JohnyP36
Update fandom-bloatware.yaml
b3ba88d 
Copied and checked rules proposed at https://github.com/letsblockit/letsblockit/issues/490#issue-1788601567
@JohnyP36
Change default to true & update template description
c18d77c 
As users of this template most likely want to use every rule, it's better to make it default set to true.
@JohnyP36 JohnyP36 marked this pull request as ready for review July 5, 2023 11:41
@JohnyP36 JohnyP36 requested a review from xvello as a code owner July 5, 2023 11:41
JohnyP36 and others added 4 commits July 5, 2023 11:46
@JohnyP36
Update fandom-bloatware.yaml
248649b
@Nomes77
Update fandom-bloatware.yaml
c42aa76
@JohnyP36
Fixed minor errors in rule syntax
4914558
@Nomes77
Update fandom-bloatware.yaml
34efb14 
@JohnyP36 I also contirbuted to this template. First, fixed an css error. Second, I suggested the rule on how to remove the yellow background on the homepage.
@JohnyP36 JohnyP36 linked an issue Jul 5, 2023 that may be closed by this pull request
Fandom.com bloat filters #490
Closed
@xvello
Copy link
Member

xvello commented Jul 5, 2023

Thanks @JohnyP36 for jumping on it! For consistency with similar templates, let's call it fandom-cleanup? I'll review it tonight.

@JohnyP36
Copy link
Member Author

JohnyP36 commented Jul 5, 2023

Thanks @JohnyP36 for jumping on it! For consistency with similar templates, let's call it fandom-cleanup? I'll review it tonight.

Yeah, fandom-cleanup would be better. I will change it.

@JohnyP36 JohnyP36 changed the title Create fandom-bloatware.yaml Create fandom-cleanup.yaml Jul 5, 2023
@xvello xvello changed the title Create fandom-cleanup.yaml fandom-cleanup: add new template for Wikia sites Jul 5, 2023
xvello
xvello approved these changes Jul 5, 2023
View reviewed changes
Copy link
Member

@xvello xvello left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me! I didn't test the rules because there's already been two pair of eyes on them.

I rebased and added @lightbulbmeow to the contributors, feel free to press merge when you think you're done!

@xvello xvello merged commit afad5cc into main Jul 6, 2023
3 checks passed
@xvello xvello deleted the JohnyP36-patch-1 branch July 6, 2023 20:13
@JohnyP36
Copy link
Member Author

JohnyP36 commented Jul 7, 2023

feel free to press merge when you think you're done!

Thank you for merging. Due to family related "issues" (not bad ones btw) I was not online yesterday.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@xvello xvello xvello approved these changes

Assignees
No one assigned
Labels
filter-data new-filter
Milestone
No milestone
3 participants
@JohnyP36 @xvello @Nomes77