Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

youtube-shorts: fix regression in search results #516

Merged
merged 1 commit into from Jul 18, 2023
Merged

Conversation

Nomes77
Copy link
Member

@Nomes77 Nomes77 commented Jul 18, 2023

Add back search-results since I could reproduce it.
afbeelding


Quick question: should we hide the COVID-19 banner, or is that too political to do?

@Nomes77 Nomes77 requested a review from xvello as a code owner July 18, 2023 07:02
@github-actions
Copy link
Contributor

Thanks for your contribution! The automated tests passed, we will review your PR shortly!

@JohnyP36
Copy link
Member

@xvello If you test this url you will see separate blocks of Shorts but also Shorts in between normal videos. It's strange as I first did not encounter this.
This is also the case with https://www.youtube.com/results?search_query=shuffle+dance+music were a first glance the Shorts are only in separate sections, but if you scroll down eventually here and there some Shorts can be found between the videos.

afbeelding

@xvello xvello changed the title Update youtube-shorts.yaml youtube-shorts: fix regression in search results Jul 18, 2023
Copy link
Member

@xvello xvello left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks a lot for catching this!

@xvello xvello merged commit 8f2364f into main Jul 18, 2023
3 checks passed
@xvello xvello deleted the BPower0036-patch-2 branch July 18, 2023 21:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
3 participants