youtube-video-duration: filter out videos by their duration

[Nomes77]

https://github.com/letsblockit/letsblockit/issues/621

[github-actions]

Thanks for your contribution! The automated tests passed, we will review your PR shortly!

[xvello]

I'll trust your final judgement, but I have reservations about this approach:

• If my memory serves me well, I don't think that ^ and $ work reliably in :has-text selectors, and @3DWORX-SA reported that the rules don't work on their side. Something is definitely necessary to avoid matching a video that runs 10:31 long though. Our old rules used \s around the time regexp, but with more experience I'd try using \b (word boundary) as a more generic boundary

• While flexible, regexp are difficult to understand for new users, and error prone for everyone. I deployed the branch at https://staging.letsblock.it/filters/youtube-short-videos, and I would not know what to input, had I not looked at the PR. We definitely need to write a proper description with some examples that people can just copy:

  • less than a minute
  • less than 10 minutes
  • one hour or more
  • 2 hours or more

• If we keep a generic regexp input, the template can be used to filter long videos, so I'd rename it youtube-video-duration, for consistency with youtube-video-title

[Nomes77]

You were right about ^ and $ not working. However \b had some unintentional side effects.
With \b , \d\d:06 will also block 10:06:28 in stead of only 28:06.
I choose for keeping it a regexp. Hopefully, the explanation is sufficient.

I think that more example are not needed.

[xvello]

Nice work! Didn't test the rules, but I trust you did.
It's deployed at https://staging.letsblock.it/filters/youtube-video-duration

[xvello]

Indeed @Nomes77, \b will not work here, as the : separator does trigger a word boundary! \s it is then.

[JohnyP36]

Late reply: yes, the rules work.