Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

google-search-cleanup: add option to hide the default search autocomplete options #638

Merged
merged 3 commits into from Feb 8, 2024

Conversation

xvello
Copy link
Member

@xvello xvello commented Feb 3, 2024

Fixes https://github.com/letsblockit/letsblockit/issues/635. Took the opportunity to convert the template to the simple rules format, as it was not making use of handlebars loops.

I kept the comments, as they are useful for maintenance. WDYT about using this ## prefix for this kind of comments? We already use the ! comment prefix to delineate templates and presets, when rendering the list.

Copy link
Contributor

github-actions bot commented Feb 3, 2024

Thanks for your contribution! The automated tests passed, we will review your PR shortly!

@xvello xvello requested a review from a team February 3, 2024 14:28
@xvello xvello merged commit e45bade into main Feb 8, 2024
4 checks passed
@xvello xvello deleted the xvello/google-zeroquery branch February 8, 2024 20:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
1 participant