Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

NTP should trigger an event to update outputs regardless of their current state. #1010

Closed
TD-er opened this issue Mar 4, 2018 · 4 comments
Closed
Labels
Category: Rules Related to the rule engine Type: Bug Considered a bug
Milestone

Comments

@TD-er
Copy link
Member

TD-er commented Mar 4, 2018

See discussion on Forum

However the Clock output issue still remains.
How to reproduce:
Put Clock output plugin within a time schedule ON period.
Remove power to ESP, replace power to ESP.
Clock output is now OFF, and will remain OFF till next ON period comes round.

What should happen:
On reinstating of power, Clock Output should compare current time to setvalue time/status and switch output accordingly.

@TD-er TD-er added Type: Bug Considered a bug Category: Rules Related to the rule engine labels Mar 4, 2018
@TD-er TD-er added this to the 2.0.0 milestone Mar 4, 2018
@TD-er
Copy link
Member Author

TD-er commented Mar 8, 2018

Added a number of new events in PR #1032
Among these is one for time update.

@sujitrp
Copy link

sujitrp commented Mar 14, 2018

Can this be closed by this solution ?
http://raspberrypi.tomasgreno.cz/ntp-client-and-server.html

@TD-er
Copy link
Member Author

TD-er commented Mar 15, 2018

@sujitrp Nope, that's just installing a local NTP server.
The thing is (as I understood it correctly), that there may be some delay between power on and first initial NTP lookup.
If the rules already fired and set some pins, they should either correct that when the time is set, or react on an event triggered by a clockset action from a successful NTP query.
Since PR #1032 , on first successful NTP query, an event is sent, so that may help in applying time based rules.

@Grovkillen
Copy link
Member

https://www.letscontrolit.com/wiki/index.php/Tutorial_Rules#.28System.29_events

These are now documented (I had missed to document the Time# events).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Category: Rules Related to the rule engine Type: Bug Considered a bug
Projects
None yet
Development

No branches or pull requests

3 participants