Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature request TaskValueSet vs [TaskName#ValueName] #1676

Closed
Grovkillen opened this issue Aug 24, 2018 · 7 comments · Fixed by #3098
Closed

Feature request TaskValueSet vs [TaskName#ValueName] #1676

Grovkillen opened this issue Aug 24, 2018 · 7 comments · Fixed by #3098
Labels
Category: UX Related to operating ESP-easy Type: Enhancement Improve something already present Type: Feature Request Add a completely new feature (e.g. controller/plugin)

Comments

@Grovkillen
Copy link
Member

Given this example rule:

On Clock#Time=Sat,16:00 do 
Taskvalueset,8,1,1
Endon

On Clock#Time=Sat,23:00 do 
Taskvalueset,8,1,0
Endon


on Pir_Sensor#Pir=1 do
if [LDR#Analog]<500 AND [Sat#dummy]=0
Publish RGB/0017F169/color/set,200,200,200
Publish RGB/0017F169/brightness/set,200 
else
Publish RGB/0017F169/brightness/set,0 
endif
endon

It would be much more intuitive for newcomers to just use [Sat#dummy]=0 instead of Taskvalueset,8,1,0. If possible we should let users use the name of the value as well as the task value set command. Essentially we could use an array with all the tasks and their value names and just replace the TaskName with its corresponding TaskNumber, and the ValueName with its corresponding ValueNumber.

@Grovkillen Grovkillen added Type: Enhancement Improve something already present Type: Feature Request Add a completely new feature (e.g. controller/plugin) Category: UX Related to operating ESP-easy labels Aug 24, 2018
@Grovkillen
Copy link
Member Author

The syntax could be:

Set,[TaskName#ValueName]=<float_value>

example:

Set,[Switch#Status]=1

@Grovkillen
Copy link
Member Author

@TD-er is this something we could/should do?

@TD-er
Copy link
Member

TD-er commented Oct 10, 2019

Sure it is more intuitive, but it also raises the question if this taskvalueset should be limited to dummy plugins only?
Maybe this is easier to add:

TaskValueSet,[foo#bar],123

Where [foo#bar] is then interpreted as task 8, value 1.

@TD-er TD-er added this to To consider in Release Mega Oct 10, 2019
@Grovkillen
Copy link
Member Author

I like that suggestion.

@Misiu
Copy link

Misiu commented Nov 5, 2019

I think that TaskValueSet,[foo#bar],123 is much readable than TaskValueSet,8,1,123

@Misiu
Copy link

Misiu commented Jul 3, 2020

@TD-er any updates on this?
I plan to return to using ESP Easy for another project :)

@TD-er
Copy link
Member

TD-er commented Jul 3, 2020

There is a pending PR for this feature request: #3098

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Category: UX Related to operating ESP-easy Type: Enhancement Improve something already present Type: Feature Request Add a completely new feature (e.g. controller/plugin)
Projects
Release Mega
  
Done
Development

Successfully merging a pull request may close this issue.

3 participants