Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Extend P1 Reader to support Swedish Version of HAN port #3875

Open
TD-er opened this issue Dec 11, 2021 · 2 comments
Open

Extend P1 Reader to support Swedish Version of HAN port #3875

TD-er opened this issue Dec 11, 2021 · 2 comments
Assignees
Labels
Category: Plugin Related to supported sensors Type: Enhancement Improve something already present

Comments

@TD-er
Copy link
Member

TD-er commented Dec 11, 2021

See request on forum

Apparently the protocol differs.

@TD-er
Copy link
Member Author

TD-er commented Mar 4, 2023

Code example: https://github.com/romix123/P1-wifi-gateway/blob/8827422c9ac9aab94b45c4e6f58495c4b0d04a00/src/decoder.ino#L192

N.B. this code example is very verbose and can use quite a lot of optimizations regarding telegram decoding.
For example there is no need to compare with strings over and over again, when we simply can decode the telegram header into various ints

@TD-er TD-er added Type: Enhancement Improve something already present Category: Plugin Related to supported sensors labels Mar 4, 2023
@TD-er TD-er self-assigned this Mar 4, 2023
@tonhuisman
Copy link
Contributor

tonhuisman commented Mar 4, 2023

An alternative could be this template-based DSMR P1 parser: https://github.com/lvzon/dsmr-p1-parser, though that doesn't support the Swedish version of the protocol, it wouldn't be hard to add. Linked to the wrong library.
This is the template-based lib I was trying to link to: https://github.com/matthijskooijman/arduino-dsmr, and it recently started support for the Swedish extensions to the protocol (or so it seems) 😅

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Category: Plugin Related to supported sensors Type: Enhancement Improve something already present
Projects
None yet
Development

No branches or pull requests

2 participants