Resolved issue https://github.com/letscontrolit/ESPEasy/issues/1844; #183

JoostDkr · 2022-04-02T09:04:03Z

Also a checkbox is added to the device-webform for switching on/off sending debug/info-log to EASpeasy-log

Update _P208_Nokia_LCD_5110.ino Resolved issue that could cause esp-easy-weblog stops working. code optimizations based on reviewers comments.

tonhuisman · 2022-04-02T09:15:41Z

_P208_Nokia_LCD_5110.ino

+//}
+void myLog(const String & message) {
+  String log;
+  if (sentlog){


The order of these 2 lines could be swapped

You could also check in the if wether the log-level is set (when compiling against a current ESPEasy mega):
if (sentlog && logLevelActiveFor(LOG_LEVEL_INFO)) {

that would save a few cpu cycles and a bit of memory

I can not use the current ESPmega (ESPEasy-mega-20220328) because of build errors......
I'm using ESPEasy_ESP32_mega-20211224 without build errors....

_P208_Nokia_LCD_5110.ino

tonhuisman · 2022-04-02T09:16:30Z

_P208_Nokia_LCD_5110.ino

+    log.reserve(message.length() + 6);
+    log += F("P208: ");
+    log += message;
+    addLog(LOG_LEVEL_INFO, log);


when compiling on current mega branch, please use addLogMove macro when appropriate

I can not use the current ESPmega (ESPEasy-mega-20220328) because of build errors......
I'm using ESPEasy_ESP32_mega-20211224 without build errors....

What build errors do you have?

I've tried to replay the scenario you have most likely taken:

Downloaded the ESPEasy-20220328 sources zip-file from the Releases page

Unzipped that file using the 7-zip tool (I always avoid using the Windows explorer .zip extracter, as that thing has been dangerously broken since the first ever release around Windows XP!)

Got the _P208_Nokia_LCD_5110.ino from this PR

Opened the unzipped folder using VSCode with PlatformIO installed

Added Adafruit PCD8544 Nokia 5110 LCD library to lib_deps in both platformio_esp32_envs.ini and platformio_esp82xx_base.ini (don't forget to add a comma after the last entry already there)

Added #define USES_P208 to the #ifdef PLUGIN_BUILD_NORMAL section of define_plugin_sets.h to include the plugin (a bit hacky, I know 👼)

Clicked Build for the normal_ESP8266_4M1M PIO configuration: successful on first execution

Clicked Build for the normal_ESP32_4M316k PIO configuration: successful after a few retries (PIO is known to sometimes have issues when switching configuration like this)

Not sure what the difference is with what you did, but it should be mostly the same, possibly you unpacked the sources-zip using the default Windows tool?

JoostDkr · 2022-04-03T21:26:54Z

Well, I tried to build a clean ESPEasy-20220328 (without _P208). I added "Adafruit PCD8544 Nokia 5110 LCD library" to lib_deps in both platformio_esp32_envs.ini and platformio_esp82xx_base.ini Build the normal_ESP8266_4M1M PIO configuration: successful on first execution Build the normal_ESP32_4M316k PIO configuration: no success even after several retries .... Build the custom_ESP32_4M316k PIO configuration: no success even after several retries ....

changes made as a result of review comments

TD-er · 2022-04-27T18:21:16Z

_P208_Nokia_LCD_5110.ino

@@ -2,6 +2,7 @@
 //################################## Plugin 208: NOKIA 5110 lcd #########################################
 //#######################################################################################################
 #include "_Plugin_Helper.h"
+#include<string> 


Not sure why this include is needed.

you're right. This is not needed

tonhuisman · 2022-08-20T10:46:08Z

@JoostDkr I have reserved Plugin ID [P141] in the ESPEasy mega repository to migrate/rewrite this plugin. (and assigned the task to me 😃)

It will be a rewrite because we prefer to use the generic ESPEasy AdafruitGFX Helper for all displays that extend the AdafruitGFX library, to have a uniform command structure for all displays, reduce code-size (it is instantiated, not #included), and thus reduce maintenance effort. And any feature implemented in the helper is immediately available for all displays (when applicable, of course).

I will add a new subcommand txl to the AdaGFX Helper to display multiple lines in a single (remote) command, very similar to what you have added to this plugin, but using the regular ESPEasy syntax as described here: letscontrolit/ESPEasy#2724

Effectively that would be something like:
pcd8544,txl,1,"Hello World",4,"Second on line 4",2,"Now on line 2",3,"Finally, line 3"
Giving output like this:

Hello World
Now on line 2
Finally, line 3
Second on line 4

But could be simplified to:
pcd8544,txl,1,"Hello World",,"Now on line 2",,"Then line 3",,"Last on line 4"
(note the double comma's to skip the auto-increment argument)

JoostDkr · 2022-08-20T11:27:40Z

@tonhuisman ,
Great job.
I'm curious about your P141. If I notice it's available I'll use it.
By the way; what is the meaning of the "1" in "pcd8544,txl,1,...."?

tonhuisman · 2022-08-20T11:32:31Z

what is the meaning of the "1" in "pcd8544,txl,1,...."?

That's supposed to address line 1, like the current plugin behavior that you extended:
pcd8544,1,hello world;2,on line 2;3,now line 3, AFAICS...

(Or maybe that was already there, didn't investigate that far)

JoostDkr · 2022-08-20T14:43:22Z

Oh. now I undestand your "autoincrement":-). Yes that was a extension made by me.

I had another extension in mind: "Control of more than 1 display". Is that something to build into your P141?

tonhuisman · 2022-08-20T14:49:44Z

"Control of more than 1 display". Is that something to build into your P141?

That's my current default for plugin development 😎, biggest challenge, at least on ESP8266, is having enough free GPIO pins and memory to hold all plugin instances 😉

tonhuisman · 2022-08-20T21:35:39Z

I've created a PR: letscontrolit/ESPEasy#4211
@JoostDkr Please test, you can download binaries from the connected Actions build, and report your results in the PR 👍

JoostDkr added 4 commits March 21, 2022 08:14

Update _P208_Nokia_LCD_5110.ino

d9fc8ab

Merge pull request #1 from JoostDkr/JoostDkr-patch-1

c629bb9

Update _P208_Nokia_LCD_5110.ino Resolved issue that could cause esp-easy-weblog stops working. code optimizations based on reviewers comments.

Merge branch 'letscontrolit:master' into master

51a2bf4

Update _P208_Nokia_LCD_5110.ino

5336383

tonhuisman reviewed Apr 2, 2022

View reviewed changes

TD-er requested changes Apr 2, 2022

View reviewed changes

_P208_Nokia_LCD_5110.ino Outdated Show resolved Hide resolved

_P208_Nokia_LCD_5110.ino Outdated Show resolved Hide resolved

_P208_Nokia_LCD_5110.ino Show resolved Hide resolved

_P208_Nokia_LCD_5110.ino Outdated Show resolved Hide resolved

tonhuisman reviewed Apr 2, 2022

View reviewed changes

JoostDkr added 2 commits April 6, 2022 21:52

Update _P208_Nokia_LCD_5110.ino

8e2ee52

changes made as a result of review comments

One html request can now contain multiple lines

26d6d9a

TD-er reviewed Apr 27, 2022

View reviewed changes

Update _P208_Nokia_LCD_5110.ino

768bbc2

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Resolved issue https://github.com/letscontrolit/ESPEasy/issues/1844; #183

Resolved issue https://github.com/letscontrolit/ESPEasy/issues/1844; #183

JoostDkr commented Apr 2, 2022

tonhuisman Apr 2, 2022

JoostDkr Apr 3, 2022

tonhuisman Apr 2, 2022

JoostDkr Apr 3, 2022

TD-er Apr 3, 2022

JoostDkr Apr 3, 2022

tonhuisman Apr 3, 2022 •

edited

Loading

JoostDkr commented Apr 3, 2022 via email •

edited

Loading

TD-er Apr 27, 2022

JoostDkr Apr 28, 2022

tonhuisman commented Aug 20, 2022

JoostDkr commented Aug 20, 2022

tonhuisman commented Aug 20, 2022 •

edited

Loading

JoostDkr commented Aug 20, 2022

tonhuisman commented Aug 20, 2022

tonhuisman commented Aug 20, 2022

Resolved issue https://github.com/letscontrolit/ESPEasy/issues/1844; #183

Are you sure you want to change the base?

Resolved issue https://github.com/letscontrolit/ESPEasy/issues/1844; #183

Conversation

JoostDkr commented Apr 2, 2022

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

tonhuisman Apr 3, 2022 • edited Loading

Choose a reason for hiding this comment

JoostDkr commented Apr 3, 2022 via email • edited Loading

Choose a reason for hiding this comment

Choose a reason for hiding this comment

tonhuisman commented Aug 20, 2022

JoostDkr commented Aug 20, 2022

tonhuisman commented Aug 20, 2022 • edited Loading

JoostDkr commented Aug 20, 2022

tonhuisman commented Aug 20, 2022

tonhuisman commented Aug 20, 2022

tonhuisman Apr 3, 2022 •

edited

Loading

JoostDkr commented Apr 3, 2022 via email •

edited

Loading

tonhuisman commented Aug 20, 2022 •

edited

Loading