Handle mocking readonly class

letsdrink · Jun 26, 2023 · 69dfe8c · 69dfe8c
1 parent d573a35
commit 69dfe8c
Show file tree

Hide file tree

Showing 3 changed files with 34 additions and 3 deletions.
diff --git a/src/Ouzo/Goodies/Utilities/DynamicProxy.php b/src/Ouzo/Goodies/Utilities/DynamicProxy.php
@@ -38,10 +38,16 @@ private static function getProxyClassDefinition(string $name, string $className)
         } else {
             $extendsClasses[] = $className;
         }
+
+        $readonly = '';
+        if ($reflectionClass->isReadOnly()){
+            $readonly = 'readonly';
+        }
         $extends = self::generateRelation('extends', $extendsClasses);
         $implements = self::generateRelation('implements', $implementsInterfaces);
-        $code = "class {$name} {$extends} {$implements} {";
-        $code .= "public \$methodHandler;\n";
+
+        $code = "{$readonly} class {$name} {$extends} {$implements} {";
+        $code .= "public ?object \$methodHandler;\n";
         $code .= "function __construct(\$methodHandler) { \$this->methodHandler = \$methodHandler; }\n";
         foreach (self::getClassMethods($reflectionClass) as $method) {
             $code .= self::generateMethod($method);

diff --git a/test/src/Ouzo/Goodies/Utilities/DynamicProxyClassesFor71.php b/test/src/Ouzo/Goodies/Utilities/DynamicProxyClassesFor71.php
@@ -35,4 +35,16 @@ public function fun1(mixed $p1): mixed
     {
         return $p1;
     }
-}
+}
+
+readonly class ReadonlyClass
+{
+    public function __construct(private string $field)
+    {
+    }
+
+    public function method():string
+    {
+        return $this->field;
+    }
+}
diff --git a/test/src/Ouzo/Goodies/Utilities/DynamicProxyTest.php b/test/src/Ouzo/Goodies/Utilities/DynamicProxyTest.php
@@ -399,4 +399,17 @@ public function shouldImplementsMockInterface()
         $this->assertTrue($result);
     }
 
+    #[Test]
+    public function shouldSedReadonlyClass(): void
+    {
+        //given
+        $testMethodHandler = new TestMethodHandler();
+        $proxy = DynamicProxy::newInstance(ReadonlyClass::class, $testMethodHandler);
+
+        //when
+        $result = $proxy->method();
+
+        //then
+        $this->assertEquals('TestMethodHandler method', $result);
+    }
 }