Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ratelimits: Exempt renewals from NewOrdersPerAccount and CertificatesPerDomain limits #7508

Closed
Tracked by #5545
beautifulentropy opened this issue May 27, 2024 · 0 comments · Fixed by #7513
Closed
Tracked by #5545
Assignees

Comments

@beautifulentropy
Copy link
Member

beautifulentropy commented May 27, 2024

This is essentially identical to what we're already doing with our legacy rate limits. The most direct way to get this done is to haul the Renewal detection up from the legacy implementation in the RA to the WFE. Then pass the result of this check through to RA NewOrderAndAuthz method using a new RPC field so it can still be excepted from the legacy rate limits. If we do add a new RPC field track a TODO to its removal along with the legacy rate limits implementation.

@beautifulentropy beautifulentropy changed the title Exempt renewals from NewOrdersPerAccount and CertificatesPerDomain limits. This must be based on an exact FQDNSet match. ratelimits: Exempt renewals from NewOrdersPerAccount and CertificatesPerDomain limits May 27, 2024
@aarongable aarongable added this to the Sprint 2024-05-28 milestone May 28, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants