New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
auto: 2.6, squeeze (fixes #640, #1046, #1078) #1257
Conversation
…e possible. When people see requirements.txt they tend to `pip install -r` straight way (c.f. certbot#1252). It's only necessary for Python2.6.
Affected by letsencrypt/boulder#756 |
@centminmod please test this PR on CentOS with Python2.6 only and see if it resolves your problems. If not, then please submit patches based on this PR's contents. |
@kuba tried it but ran into error - full log of steps done and output at https://gist.github.com/centminmod/6af9b14f9fe75806d604 CentOS 6.7 with python 2.6.6
edit: sorry forgot to checkout your branch heh
output with correct branch checked out https://gist.github.com/centminmod/6af9b14f9fe75806d604 if python 2.6 is supported again, might want to hide
|
We can think about hiding those warnings later, although I'm in favor of leaving them as they are now - at least user has a clear message that they should probably update their OS. I'm glad to hear that it worked for CentOS 6.7 with Python 2.6.6! Thanks for testing. |
maybe have a clear message at end of install
|
Thank you, i been able to install client in CentOS6, with some warnings. Would be great to see it commited. |
@pde, can you have a look? |
# This first clause is redundant with the third, but hedging on portability | ||
if [ "$arg" = "-v" ] || [ "$arg" = "--verbose" ] || echo "$arg" | grep -E -- "-v+$" ; then | ||
VERBOSE=1 | ||
fi | ||
done | ||
|
||
if [ -f /etc/debian_version ] ; then | ||
# squeeze needs Python 2.6, `python2` doesn't exist | ||
if grep -q '^6\.0' /etc/debian_version ; then |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think it's safer to test for the actual prevailing conditions that cause the problem rather than an OS version stamp that should indicate it. It's too common for people to have a mix of different packages on their systems.
So check for something like: no python2
or python2.7
, python
exists but python --version
indicates 2.6?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think it's out of scope for this PR. Moreover, proposed suggestion is much more likely to break. Let's keep it simple for now, and just fix squeeze.
@kuba Please forgive me as I'm not a professional developer, so I'm trying to wade through this. I pulled this git: git clone -b auto-2.6-squeeze https://github.com/kuba/letsencrypt then tried running with --manual It got further than before, but is still failing. Please see below:
|
@CorySvensson, it's not the best place to discuss such problems, unless they are relevant with the PR. Please join us at IRC: https://letsencrypt.readthedocs.org/en/latest/using.html#getting-help |
I have the same problem as @centminmod and I'm using Python 2.7.6 on Ubuntu 14.04.3 |
I can confirm that this branch makes letsencrypt-auto work on Squeeze; I just generated a cert that way. Thank you!! |
Closing in favour of #1361, which includes all of this. |
Tested on DO squeeze droplet.