Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

auto: 2.6, squeeze (fixes #640, #1046, #1078) #1257

Closed
wants to merge 5 commits into from

Conversation

kuba
Copy link
Contributor

@kuba kuba commented Oct 31, 2015

Tested on DO squeeze droplet.

@kuba
Copy link
Contributor Author

kuba commented Oct 31, 2015

Affected by letsencrypt/boulder#756

@kuba
Copy link
Contributor Author

kuba commented Oct 31, 2015

@centminmod please test this PR on CentOS with Python2.6 only and see if it resolves your problems. If not, then please submit patches based on this PR's contents.

@centminmod
Copy link

@kuba tried it but ran into error - full log of steps done and output at https://gist.github.com/centminmod/6af9b14f9fe75806d604

CentOS 6.7 with python 2.6.6

Creating virtual environment...
Updating letsencrypt and virtual environment dependencies...../root/.local/share/letsencrypt/lib/python2.6/site-packages/pip/_vendor/requests/packages/urllib3/util/ssl_.py:90: InsecurePlatformWarning: A true SSLContext object is not available. This prevents urllib3 from configuring SSL appropriately and may cause certain SSL connections to fail. For more information, see https://urllib3.readthedocs.org/en/latest/security.html#insecureplatformwarning.
  InsecurePlatformWarning
Command "python setup.py egg_info" failed with error code 1 in /tmp/pip-build-pxI698/ConfigArgParse
/root/.local/share/letsencrypt/lib/python2.6/site-packages/pip/_vendor/requests/packages/urllib3/util/ssl_.py:90: InsecurePlatformWarning: A true SSLContext object is not available. This prevents urllib3 from configuring SSL appropriately and may cause certain SSL connections to fail. For more information, see https://urllib3.readthedocs.org/en/latest/security.html#insecureplatformwarning.
  InsecurePlatformWarning

edit: sorry forgot to checkout your branch heh

git clone -b auto-2.6-squeeze https://github.com/kuba/letsencrypt

output with correct branch checked out https://gist.github.com/centminmod/6af9b14f9fe75806d604

if python 2.6 is supported again, might want to hide

/root/.local/share/letsencrypt/lib/python2.6/site-packages/cryptography/__init__.py:25: DeprecationWarning: Python 2.6 is no longer supported by the Python core team, please upgrade your Python.
  DeprecationWarning

@kuba
Copy link
Contributor Author

kuba commented Oct 31, 2015

We can think about hiding those warnings later, although I'm in favor of leaving them as they are now - at least user has a clear message that they should probably update their OS. I'm glad to hear that it worked for CentOS 6.7 with Python 2.6.6! Thanks for testing.

@centminmod
Copy link

maybe have a clear message at end of install

letsencrypt client successfully installed

@samm-git
Copy link

samm-git commented Nov 1, 2015

Thank you, i been able to install client in CentOS6, with some warnings. Would be great to see it commited.

@kuba
Copy link
Contributor Author

kuba commented Nov 2, 2015

@pde, can you have a look?

# This first clause is redundant with the third, but hedging on portability
if [ "$arg" = "-v" ] || [ "$arg" = "--verbose" ] || echo "$arg" | grep -E -- "-v+$" ; then
VERBOSE=1
fi
done

if [ -f /etc/debian_version ] ; then
# squeeze needs Python 2.6, `python2` doesn't exist
if grep -q '^6\.0' /etc/debian_version ; then
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think it's safer to test for the actual prevailing conditions that cause the problem rather than an OS version stamp that should indicate it. It's too common for people to have a mix of different packages on their systems.

So check for something like: no python2 or python2.7, python exists but python --version indicates 2.6?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think it's out of scope for this PR. Moreover, proposed suggestion is much more likely to break. Let's keep it simple for now, and just fix squeeze.

@pde pde changed the title auto: 2.6, squeeze (fixes #640, #1046, #1078) auto: 2.6, squeeze (fixes #640, #1046, #1078) [needs revision] Nov 2, 2015
@CorySvensson
Copy link

@kuba Please forgive me as I'm not a professional developer, so I'm trying to wade through this.

I pulled this git:

git clone -b auto-2.6-squeeze https://github.com/kuba/letsencrypt

then tried running with --manual

It got further than before, but is still failing. Please see below:

...@...com [~/letsencrypt]# ./letsencrypt-auto --manual
Updating letsencrypt and virtual environment dependencies.....Requirement already satisfied (use --upgrade to upgrade): ConfigArgParse from git+https://github.com/kuba/ConfigArgParse.git@python2.6-0.9.3#egg=ConfigArgParse in /home/corysven/.local/share/letsencrypt/lib/python2.6/site-packages (from -r py26reqs.txt (line 1))
Requirement already satisfied (use --upgrade to upgrade): argparse in /home/corysven/.local/share/letsencrypt/lib/python2.6/site-packages (from ConfigArgParse->-r py26reqs.txt (line 1))
Requirement already satisfied (use --upgrade to upgrade): ordereddict in /home/corysven/.local/share/letsencrypt/lib/python2.6/site-packages (from ConfigArgParse->-r py26reqs.txt (line 1))
Requirement already satisfied (use --upgrade to upgrade): unittest2 in /home/corysven/.local/share/letsencrypt/lib/python2.6/site-packages (from ConfigArgParse->-r py26reqs.txt (line 1))
Requirement already satisfied (use --upgrade to upgrade): traceback2 in /home/corysven/.local/share/letsencrypt/lib/python2.6/site-packages (from unittest2->ConfigArgParse->-r py26reqs.txt (line 1))
Requirement already satisfied (use --upgrade to upgrade): six>=1.4 in /home/corysven/.local/share/letsencrypt/lib/python2.6/site-packages (from unittest2->ConfigArgParse->-r py26reqs.txt (line 1))
Requirement already satisfied (use --upgrade to upgrade): linecache2 in /home/corysven/.local/share/letsencrypt/lib/python2.6/site-packages (from traceback2->unittest2->ConfigArgParse->-r py26reqs.txt (line 1))
.Command "python setup.py egg_info" failed with error code 1 in /tmp/pip-build-DLaxUR/cffi

@kuba
Copy link
Contributor Author

kuba commented Nov 4, 2015

@CorySvensson, it's not the best place to discuss such problems, unless they are relevant with the PR. Please join us at IRC: https://letsencrypt.readthedocs.org/en/latest/using.html#getting-help

@kuba kuba changed the title auto: 2.6, squeeze (fixes #640, #1046, #1078) [needs revision] auto: 2.6, squeeze (fixes #640, #1046, #1078) Nov 4, 2015
@squarepegsys
Copy link

I have the same problem as @centminmod and I'm using Python 2.7.6 on Ubuntu 14.04.3

@cure
Copy link
Contributor

cure commented Nov 5, 2015

I can confirm that this branch makes letsencrypt-auto work on Squeeze; I just generated a cert that way. Thank you!!

@pde
Copy link
Member

pde commented Nov 5, 2015

Closing in favour of #1361, which includes all of this.

@pde pde closed this Nov 5, 2015
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

7 participants