Fix CLI --help for OS X #846
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I used |
| @@ -1,5 +1,6 @@ | |||
| """Registers functions to be called if an exception or signal occurs.""" | |||
| import logging | |||
| import sys | |||
There was a problem hiding this comment.
nit: we order imports alphabetically (and group them by stdlib/3rd-party/local sections)
|
LGTM. Thanks! Could the merger fix above comment in case it's not resolved earlier? @BKreisel, could you check it, please? :) |
|
LGTM as well. I've confirmed the issue outlined in #841 and that this patch resolves the issue. |
OS X's signal module doesn't have SIGPWR. Don't try to use it. Fixes #841
|
@kuba I've reordered the imports. Thanks. |
|
Thanks for the patch @davidxia. lgtm |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.