Fix issue where intermediate CA was self signed #148
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Issuer Certificate was being issued as self signed, rather than signed by the root CA, causing issues with Google Chrome and MS Edge to determine that the certificate was invalid. Fix to ensure that the signer's certificate is passed to x509.CreateCertificate as per docs https://golang.org/pkg/crypto/x509/#CreateCertificate
cpu
approved these changes
Jul 26, 2018
There was a problem hiding this comment.
Great catch @AStevensTaylor - thank you! Your PR looks good to me.
This was referenced Jul 29, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issuer Certificate was being issued as self signed, rather than signed by the root CA, causing issues with Google Chrome and MS Edge to determine that the certificate was invalid.
Fix to ensure that the signer's certificate is passed to x509.CreateCertificate as per docs https://golang.org/pkg/crypto/x509/#CreateCertificate