Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Document exposing API and management ports when not using docker-compose.yaml #465

Merged
merged 2 commits into from
May 31, 2024

Conversation

pgporada
Copy link
Member

@pgporada pgporada commented May 24, 2024

#444 removed exposing the API and management ports directly in the Dockerfile in favor of the docker-compose.yml. Not everyone will be using docker compose so let's document how it should be done.

Fixes #452

@mcpherrinm
Copy link
Contributor

It’s not quite so simple, because we use the same docker file for both pebble and pebble-challtestsrv

@pgporada
Copy link
Member Author

We should split that apart then so they behave appropriately running as one-off docker run's or docker compose up.

@mcpherrinm
Copy link
Contributor

EXPOSE is only really for the use docker run --publish-all instead of specifying the ports with -p, which is at most a minor inconvenience IMO, so we should consider how much extra complexity we want to add here to support that

@pgporada
Copy link
Member Author

How about switching all the documented docker run steps to add in those ports?

@pgporada pgporada changed the title Expose API and management ports in dockerfile Document exposing API and management ports when not using docker-compose.yaml May 24, 2024
@pgporada pgporada merged commit ad9e5bb into main May 31, 2024
14 checks passed
@pgporada pgporada deleted the fix-port-mapping branch May 31, 2024 18:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Cannot set DNS server in Docker image
3 participants