Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: crawl valid urls #450

Merged
merged 1 commit into from
Dec 17, 2022
Merged

fix: crawl valid urls #450

merged 1 commit into from
Dec 17, 2022

Conversation

abhisaha1
Copy link
Member

No description provided.

@abhisaha1 abhisaha1 merged commit 48452ac into master Dec 17, 2022
const isValidUrl = (urlString) => {
var urlPattern = new RegExp(
"^(https?:\\/\\/)?" + // validate protocol
"((([a-z\\d]([a-z\\d-]*[a-z\\d])*)\\.)+[a-z]{2,}|" + // validate domain name

Check failure

Code scanning / CodeQL

Inefficient regular expression

This part of the regular expression may cause exponential backtracking on strings starting with '0' and containing many repetitions of '0'.
@abhisaha1 abhisaha1 deleted the crawl-valid-urls branch September 3, 2023 15:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant