Big refactor, remove deprecated lifecycle methods #58
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tienpham94
changed the title
|
wow, this is awesome. A big improvement for sure. I will review the code. ccing @alder for some testing. We should merge is ASAP. |
tienpham94
changed the title
|
Checked this branch. Functionality works ok. I found some issues, but they do not related to these changes. PR can be merged. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Address issue #56
I have tested both manually and with
yarn test, also fixed an existing bug which user cannot change info of a Media picture, but with this big change it would be great to pull my branch and test locally.