feat(transport-smtp): Support to SASL draft login challenge #911
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 3 commits
February 14, 2024 21:07
In https://www.ietf.org/archive/id/draft-murchison-sasl-login-00.txt, base64 encoded "User Name" is "VXNlciBOYW1lAA==", and "Password" is "UGFzc3dvcmQA". But using the base64 crate (or any other base64 converter), "User Name" is "VXNlciBOYW1l" and "Password" is "UGFzc3dvcmQ=". This means VXNlciBOYW1lAA== and UGFzc3dvcmQA is not accepted by lettre-based programs. So I added the source to accept these Strings.
It was "\0"..
|
We should actually totally ignore the challenge content and just rely on challenge order:
But it requires architecture changes, let's merge this already. |
|
Thanks @hodumayo, and sorry for the late review. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Inhttps://www.ietf.org/archive/id/draft-murchison-sasl-login-00.txt,base64 encoded "User Name" is "VXNlciBOYW1lAA==",and "Password" is "UGFzc3dvcmQA".But using the base64 crate (or any other base64 converter),"User Name" is "VXNlciBOYW1l",and "Password" is "UGFzc3dvcmQ=".This means "VXNlciBOYW1lAA==" and "UGFzc3dvcmQA" is not accepted by lettre-based programs.I think something is wrong with the sasl draft document, but many programs already follow this standard.So I added the code to accept these Strings.Edited:
Currently, the lettre library does not support "User Name\0" and "Password\0" as described in the ietf draft, and this can cause compatibility issues with projects like stalwart mail that follow the ietf draft. Therefore, I would like to address the compatibility issue with this request.