Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Bug] Since v2.3.0, tiling area margin only applies to primary monitor #27

Closed
KaKi87 opened this issue Oct 30, 2023 · 4 comments
Closed
Assignees
Labels
enhancement New feature or request

Comments

@KaKi87
Copy link

KaKi87 commented Oct 30, 2023

Which means that windows on my secondary monitors are covered by my taskbar.

Thanks

@leukipp leukipp self-assigned this Nov 28, 2023
@leukipp leukipp added the enhancement New feature or request label Nov 28, 2023
@leukipp
Copy link
Owner

leukipp commented Dec 3, 2023

Actually the edge_margin property is intended to be used to "unhide" desktop information's (e.g. conky infographics), which are generally only rendered on the primary screen.

Static taskbars on primary and/or/across secondary screens should be recognized and factored into the internal desktop dimension calculation, without the need to use edge_margin .
Please provide screenshots, run cortile with cortile -v and check the first view log outputs for differences in "Screens" (full monitor) and "Desktop" (tiling area) dimensions.

@KaKi87
Copy link
Author

KaKi87 commented Dec 3, 2023

provide screenshots

On both versions, windows are positioned in disregard of the taskbar on every monitor when not using edge_margin :

run cortile with cortile -v

Here's v2.2 :

INFO[2023-12-03T22:09:31+01:00] Starting [cortile v2.2.1-23db49d, built on 2023-08-02T19:45:29Z] 
INFO[2023-12-03T22:09:31+01:00] Connected to X server [Mutter (Muffin)]      
INFO[2023-12-03T22:09:31+01:00] Screens [[(0, 0) 1920x1080] [(1920, 0) 1920x1080] [(3840, 0) 1920x1080]] 
INFO[2023-12-03T22:09:31+01:00] Desktops [[(0, 0) 1920x1080] [(1920, 0) 1920x1080] [(3840, 0) 1920x1080]] 
INFO[2023-12-03T22:09:31+01:00] Ignore pinned window [Nemo-desktop]          
INFO[2023-12-03T22:09:31+01:00] Ignore pinned window [Nemo-desktop]          
INFO[2023-12-03T22:09:31+01:00] Ignore pinned window [Nemo-desktop]

Here's v2.3 :

INFO[2023-12-03T22:10:02+01:00] Starting [cortile v2.3.0-7c42aea, built on 2023-10-30T19:21:08Z] 
INFO[2023-12-03T22:10:02+01:00] Connected to X server [Mutter (Muffin)]      
INFO[2023-12-03T22:10:02+01:00] Using primary screen [DisplayPort-0]         
INFO[2023-12-03T22:10:02+01:00] Using primary screen [DisplayPort-0]         
INFO[2023-12-03T22:10:02+01:00] Screens [{84 DisplayPort-0 false [(0, 0) 1920x1080]} {85 DisplayPort-1 true [(1920, 0) 1920x1080]} {87 HDMI-A-0 false [(3840, 0) 1920x1080]}] 
INFO[2023-12-03T22:10:02+01:00] Desktops [{84 DisplayPort-0 false [(0, 0) 1920x1080]} {85 DisplayPort-1 true [(1920, 0) 1920x1080]} {87 HDMI-A-0 false [(3840, 0) 1920x1080]}] 
INFO[2023-12-03T22:10:02+01:00] Ignore window with type _NET_WM_WINDOW_TYPE_DESKTOP [Nemo-desktop] 
INFO[2023-12-03T22:10:02+01:00] Ignore window with type _NET_WM_WINDOW_TYPE_DESKTOP [Nemo-desktop] 
INFO[2023-12-03T22:10:02+01:00] Ignore window with type _NET_WM_WINDOW_TYPE_DESKTOP [Nemo-desktop]

Thanks

@leukipp
Copy link
Owner

leukipp commented Dec 10, 2023

For some reasons the panel auto-detection doesn't seem to work under Mutter.

They are now two config entries, edge_margin and edge_margin_primary with the latest release. This should give everyone the desired flexibility. Feel free to reopen if you encounter any other problems.

@leukipp leukipp closed this as completed Dec 10, 2023
@KaKi87
Copy link
Author

KaKi87 commented Dec 28, 2023

panel auto-detection doesn't seem to work under Mutter

Don't you intend to fix it ?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

2 participants