Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

by-class - domina 1.0.2-SNAPSHOT #42

Closed
magomimmo opened this issue Jan 15, 2013 · 1 comment
Closed

by-class - domina 1.0.2-SNAPSHOT #42

magomimmo opened this issue Jan 15, 2013 · 1 comment

Comments

@magomimmo
Copy link
Contributor

By including domina 1.0.2-SNAPSHOT instead of 1.0.0, by-class does not work any more with the following JS message:

Uncaught Error: Doesn't support name: modern_dbg.js:17727
name modern_dbg.js:17727
domina.t3861.domina$DomContent$nodes$arity$1 modern_dbg.js:25216
nodes modern_dbg.js:25094
destroy_BANG_ modern_dbg.js:25301
remove_help modern_dbg.js:32687
(anonymous function) modern_dbg.js:26173
goog.events.Listener.handleEvent modern_dbg.js:24464
goog.events.fireListener modern_dbg.js:24798
goog.events.handleBrowserEvent_ modern_dbg.js:24919
(anonymous function)

But it works using .getElementsByClassName interop.
You can check this behaviour with the following source code included in a repo:

https://github.com/magomimmo/modern-cljs/blob/domina-by-name/src/cljs/modern_cljs/shopping.cljs

@magomimmo
Copy link
Contributor Author

Hi Luke, I saw that you merged the pull requeste. So this is closed at the moment. Thanks.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant