Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Breaking change in v2.2.1 #61

Closed
willwhite opened this issue May 12, 2015 · 5 comments
Closed

Breaking change in v2.2.1 #61

willwhite opened this issue May 12, 2015 · 5 comments

Comments

@willwhite
Copy link

The recent 2.2.1 patch release includes a breaking change around validation of the location argument. This change is breaking downstream users of this project including https://github.com/mhart/dynalite.

semver reserves minor and patch level increments for backwards-compatible changes only. Any chance v2.2.1 can be unpublished and rerolled as a major v3.0.0 release?

willwhite added a commit to willwhite/memdown that referenced this issue May 13, 2015
Hard pins to abstract-leveldown@2.2.0 for now as a stopgap for
Level/abstract-leveldown#61.
@juliangruber
Copy link
Member

can you explain why this is a breaking change? it was never documented what an empty string "" as location would do and so this is a fix as it prevents unexpected behavior.

@juliangruber
Copy link
Member

ah i guess if location doesn't matter, like when using memdown, people like to pass an empty string?

@juliangruber
Copy link
Member

memdown does that for example: https://github.com/Level/memdown/blob/master/memdown.js#L124

@juliangruber
Copy link
Member

i reverted and published 2.2.2, sorry for the trouble. i'm opening a new issue for a better strategy.

@willwhite
Copy link
Author

Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants