Adding _seek to SubIterator

[MeirionHughes]

So I've been trying to add support for _seek on SubIterator. In principle the change is simply the added lines:

SubIterator.prototype._seek = function (key) {
  this.iterator.seek(concat(this.prefix, key))
}

but this never gets called.

If I do:

    var db = levelup(memdown())
    var sub = subdb(db, 'sub')

    db.once('open', function () {
     var it = sub.iterator({ keyAsBuffer: false, valueAsBuffer: false })
   
     console.log(it)

I get...

Iterator {
...
  it:
   SubIterator {
     iterator:
      MemIterator {
       ...

It seems clear Iterator is not calling this.it.seek, but I have no idea where this Iterator prototype is. Any ideas?

[vweevers]

That's because the iterator created with sub.iterator() is an encoding-down iterator which doesn't expose seek (yet).

[vweevers]

To be precise, it doesn't forward it yet.

[MeirionHughes]

dam... I didn't bother to check there as it wasn't in my chain. cheers.

[MeirionHughes]

oh balls... I pushed to the wrong origin. will revert.