Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Don't mutate arguments in SubIterator._next #93

Merged
merged 1 commit into from
Jun 26, 2020

Conversation

andymatuschak
Copy link
Contributor

This method mutates an argument and subsequently references arguments. In JS strict mode, the arguments symbol references a copy of the initial function arguments; it does not reflect mutations made to the arguments in the body of the function (see spec)—so the mutation is inadvertently dropped. I've fixed this issue by using the argument names directly rather than the arguments objects.

@vweevers vweevers merged commit 5513c83 into Level:master Jun 26, 2020
@vweevers
Copy link
Member

5.0.1

Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants