Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

161 Timestamp disabled users should get flash error #162

Merged
merged 1 commit into from
Aug 10, 2022
Merged

161 Timestamp disabled users should get flash error #162

merged 1 commit into from
Aug 10, 2022

Conversation

nicoavn
Copy link

@nicoavn nicoavn commented Aug 10, 2022

Resolves #161

Re-enabling users will also clear out the disabled_utc timestamp, w…
8f12251 
…hen its value is not changed along with re-enabling.

Using User's `is_active` attribute instead of `is_enabled` to render a flash error on sign-in attempts.
Adding and updating tests.
@nicoavn nicoavn self-assigned this Aug 10, 2022
@nicoavn
Copy link
Author

nicoavn commented Aug 10, 2022

I'm not sure what is breaking the build, as all tests seem to be passing when run with pytest alone.

@guruofgentoo
Copy link
Member

FWIW the breakage is from level12/keg#184, broken by a flask update.

@guruofgentoo guruofgentoo merged commit 9330f62 into master Aug 10, 2022
@guruofgentoo guruofgentoo deleted the 161-timestamp-disabled-users-should-get-flash-error branch August 10, 2022 12:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@guruofgentoo guruofgentoo Awaiting requested review from guruofgentoo

Assignees

@nicoavn nicoavn

@guruofgentoo guruofgentoo

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Timestamp disabled users should get flash error, clear disabled_utc timestamp
2 participants
@nicoavn @guruofgentoo