Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Further investigate why SA fails with soft-delete mixin #117

Closed
nZac opened this issue Nov 19, 2019 · 1 comment
Closed

Further investigate why SA fails with soft-delete mixin #117

nZac opened this issue Nov 19, 2019 · 1 comment
Assignees

Comments

@nZac
Copy link
Contributor

nZac commented Nov 19, 2019

  • The tests seem to fail randomly, but upon further review they seem to fail on any fresh installation. By removing recreate=false in the tox configuration, the failures go away.

  • The main issue is the None type doesn't have __dict__, the other two errors seem to be related or directly caused by that one.

  • I was, at one point, able to get the tests to pass in 3.8 with minimal changes, but they then failed on 3.6... whack a mole.

  • By adding a simple delay to the test, it seemed to fix the issue, but then it popped back up again.

nZac pushed a commit that referenced this issue Nov 19, 2019
"Fixes" issues with tests... by ignoring the tests and creating an issue. 

Ref GH-117
@guruofgentoo
Copy link
Member

I believe the test(s) in question are currently skipped.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants