Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Use CSS media instead of useWindowWidth hook for layout #563

Closed
adamazad opened this issue Jan 24, 2022 · 1 comment
Closed

Use CSS media instead of useWindowWidth hook for layout #563

adamazad opened this issue Jan 24, 2022 · 1 comment
Assignees
@0xVenky
Labels
enhancement New feature or request good first issue Good for newcomers

Comments

@adamazad
Copy link
Contributor

Too many React hooks are not healthy and degrade the app performance with too unnecessary calculations.

AC

  • useWindowsSize hook is removed and replaced with a CSS alternative.
@adamazad adamazad added enhancement New feature or request good first issue Good for newcomers labels Jan 24, 2022
@Mi-Lan
Copy link
Collaborator

Mi-Lan commented Jan 31, 2022

@adamazad I was thinking about this and the only issue I see is if we need to programatically use window size I think its used in those cases...

@0xVenky 0xVenky closed this as completed Sep 14, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@0xVenky 0xVenky

Labels
enhancement New feature or request good first issue Good for newcomers
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@adamazad @Mi-Lan @0xVenky