Fix ecoBridge infinite loop

[0xVance]

Summary

Fixes #1626

I think _activeBridge check was introduced to improve logging when error happends but it occured to be the error 🐛

[netlify]

✅ Deploy Preview for swapr ready!

Name	Link
🔨 Latest commit	a97727b
🔍 Latest deploy log	https://app.netlify.com/sites/swapr/deploys/63ad79e77deb150008ce1bcf
😎 Deploy Preview	https://deploy-preview-1628--swapr.netlify.app/
📱 Preview on mobile	Toggle QR Code... Use your smartphone camera to open QR code link.

---

To edit notification comments on pull requests, go to your Netlify site settings.

[MilanVojnovic95]

Tested and:

USDC from Ethereum to Arbitrum (Socket) ✅
USDC from Ethereum to Gnosis (Connext) ✅
USDC from Arbitrum One to Gnosis (Socket) ✅

USDC from Gnosis to Polygon ❌

On Swapr it shows as if the bridge failed:

But on socketscan it shows that it's still in progress:

USDC from Ethereum to Gnosis (OmniBridge) ❌

When user clicks on the "Collect" option, they receive the following error message:

Also another thing I noticed:

the status "failed" does not change, even when you go to check the transaction id status "bridge in progress" and even when "Bridge successful" on Swapr, it appears in the status "failed".

[0xVenky]

Hey, this needs a fix for this PR. I think this is a different issue, but still, lets fix everything at once.

The other one related to Omnibridge, lets ignore that for now and create a seperate issue for this one and will try to fix it in the coming iterations.

[berteotti]

I made a transaction from Gnosis to Ethereum (Connext) and couldn't claim it on Ethereum. Don't know if this is fixed in this PR :)

[0xVenky]

I made a transaction from Gnosis to Ethereum (Connext) and couldn't claim it on Ethereum. Don't know if this is fixed in this PR :)

Hey, This PR should have fixed it. :)

[Mi-Lan]

• This fixes it! Although I get the same error message Milan outlined that gas estimation failed

• We can tackle that in another issue though
• Im also getting infinite loading when waiting for confirmation for Omni bridge

[0xVance]

Tested and:

USDC from Ethereum to Arbitrum (Socket) white_check_mark USDC from Ethereum to Gnosis (Connext) white_check_mark USDC from Arbitrum One to Gnosis (Socket) white_check_mark

USDC from Gnosis to Polygon x

On Swapr it shows as if the bridge failed:

But on socketscan it shows that it's still in progress:

USDC from Ethereum to Gnosis (OmniBridge) x

When user clicks on the "Collect" option, they receive the following error message:

Also another thing I noticed:

the status "failed" does not change, even when you go to check the transaction id status "bridge in progress" and even when "Bridge successful" on Swapr, it appears in the status "failed".

Imo Socket has a bug on /bridge-status endpoint.

When I bridged XDAI to USDC from Gnosis to Polygon I got this:

The reason why status becomes 'Failed' is because /bridge-status endpoint returns 500 if called right after initiating bridging (which indicates some kind of bug). Few seconds later same call returns correct result.

My suggestion for fixing this:

• in pending tx listener for socket, when it responds with 500 don't change status to failed but just skip it for next 10s
• on app init go through all socket transactions with 'failed' status and retry them

I'll add a commit with this briefly

[0xVance]

• This fixes it! Although I get the same error message Milan outlined that gas estimation failed

• We can tackle that in another issue though
• Im also getting infinite loading when waiting for confirmation for Omni bridge

Regarding Connext claiming - everything works fine now EXCEPT:

• our Connext bridge implementation is incomplete - every bridging that is made through it has expiry date. If user doesn't claim till then bridging goes to 'Cancelled' state on Connext and and hell knows how to get funds back (maybe directly through contract interaction, I haven't looked yet). We don't have any information nor expiration handling which will be frustrating to the users.
  
• as for now I have no good fix for this problem as it would require from me doing some research around Connext ecosystem and figuring out how to handle cancelled bridgings.

[adamazad]

Looks good to me!

[adamazad]

I could be wrong, but it should be || instead no?

[MilanVojnovic95]

Retested and still I get this

The only thing that has been successfully changed is that the "cancelled" status for successful transactions is no longer displayed now it's "Confirmed" status.
Everything else seems ok. 👍 ✅