-
Notifications
You must be signed in to change notification settings - Fork 6
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Atom syndication #26
Open
andete
wants to merge
8
commits into
leven-the-blog:master
Choose a base branch
from
andete:atom_syndication
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Atom syndication #26
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… the title and the date because relying on the filesystem though very elegant and simple is not always what you want
This looks amazing! I'll read over it as soon as I get home. :) |
I have a few (very minor) questions:
I can write the rest of the code now, that's the easy part. Again, thanks for the massive contribution! :) |
Hey,
the reason for updated is that posts can have a date, which is the date it
was first posted, and an updated date, which is the date it was potentially
updated at a later point.
The updated matters for feed readers, and the normal date is the date it
shows as being posted, even when updated, cause otherwise the time order of
the posts would change.
I hope that makes sense.
Yes, I used feed.html because of the template engine. It doesn't _really_
matter though, no, it's just a name?
I don't mind about the frontmatter syntax, happy to implement the change
for my blogs, I've only got a few posts for now anyway.
Joost
…On Sun, Mar 4, 2018 at 9:24 AM Ram ***@***.***> wrote:
I have a few (very minor) questions:
- Post.date is already the last updated (i.e. modified) date, so
what's the point of adding an updated_date field, too?
- Instead of changing the default date format in build_atom_feed,
wouldn't it be easier to use date.iso8601 in the template? That's
basically what it's there for, anyway.
- config.date should probably be replaced with another global named now
.
- feed.html should be feed.xml, and it isn't currently being written
out in init/mod.rs like it should be. *Edit*: This is my fault,
because the template engine assumes the extension is .html, doesn't it?
- I'm still not sure which syntax is better for frontmatter, but I'm
leaning towards ^---$ (i.e. --- that is on its own line). Is it okay
if I use that instead?
I can write the rest of the code now, that's the easy part. Again, thanks
for the massive contribution! :)
—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub
<#26 (comment)>,
or mute the thread
<https://github.com/notifications/unsubscribe-auth/AAqDeSEhfGCjA0tFBSyROuAKA15ugQ3cks5ta6SmgaJpZM4SU0Us>
.
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Implementation for #25 .
Allows to generate an atom feed for the blog. Validated with w3c and tested with feedly and found to work fine.
Following fields are required for it in Leven.toml:
Optionally a date can also be specified to be used for the generated feed xml, if not specified, now is used.