Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

mgf.read ignores use_index if source is str (4.3.3) #16

Closed
lars-kolbowski opened this issue Oct 29, 2020 · 1 comment
Closed

mgf.read ignores use_index if source is str (4.3.3) #16

lars-kolbowski opened this issue Oct 29, 2020 · 1 comment
Assignees

Comments

@lars-kolbowski
Copy link

Hi,
just noticed that a test I had failed when upgrading from 4.3.2 to 4.3.3.
When passing use_index=False to mgf.read() with a str filepath the aux._check_use_index() overwrites this back to True. So one always ends up with an IndexedMGF when passing a str filepath and it's no longer possible to create an MGF object. Was wondering if this is an intended change.
Thank you!

@levitsky
Copy link
Owner

Hi, thanks for the heads-up. This was definitely not intentional. I will investigate.
As a workaround, you can use MGF(...) instead of read(...).

@levitsky levitsky self-assigned this Nov 2, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants